Page MenuHomePhabricator
Differential D14205

rename fetchAllCommunityInfosWithNames -> fetchNativeDrawerAndDirectoryInfos
ClosedPublic
Actions

Authored by varun on Jan 14 2025, 2:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 2:32 PM
Unknown Object (File)
Mon, Apr 21, 9:36 AM
Unknown Object (File)
Mon, Apr 21, 6:46 AM
Unknown Object (File)
Mon, Apr 21, 6:43 AM
Unknown Object (File)
Sun, Apr 20, 6:46 AM
Unknown Object (File)
Wed, Apr 16, 3:56 AM
Unknown Object (File)
Mar 22 2025, 8:50 AM
Unknown Object (File)
Mar 16 2025, 6:20 AM
View All 48 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM2634be67d26f: rename fetchAllCommunityInfosWithNames -> fetchNativeDrawerAndDirectoryInfos
Summary

Depends on D14204

Test Plan

was still able to call endpoint from community drawer

this API isn't being used anywhere yet so no need to worry about older clients

Diff Detail

Repository
rCOMM Comm
Branch
directory (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Jan 14 2025, 2:57 PM
varun held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptJan 14 2025, 2:57 PM
Harbormaster failed remote builds in B33243: Diff 46685!Jan 14 2025, 3:11 PM
varun updated this revision to Diff 46847.Jan 29 2025, 5:36 PM

CI

varun edited the test plan for this revision. (Show Details)Jan 29 2025, 5:36 PM
varun edited the test plan for this revision. (Show Details)
Harbormaster completed remote builds in B33350: Diff 46847.Jan 29 2025, 5:56 PM
varun published this revision for review.Jan 29 2025, 5:57 PM
ashoat accepted this revision.Jan 30 2025, 10:55 AM
ashoat added inline comments.
keyserver/src/endpoints.js
509 ↗(On Diff #46847)

Is it definitely safe to rename this? No calls from production?

This revision is now accepted and ready to land.Jan 30 2025, 10:55 AM
varun added inline comments.Feb 3 2025, 4:32 PM
keyserver/src/endpoints.js
509 ↗(On Diff #46847)

yeah

varun added a child revision: D14378: [keyserver] boost certain community IDs.Feb 17 2025, 3:46 PM
Closed by commit rCOMM2634be67d26f: rename fetchAllCommunityInfosWithNames -> fetchNativeDrawerAndDirectoryInfos (authored by varun). · Explain WhyMar 1 2025, 2:25 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM2634be67d26f: rename fetchAllCommunityInfosWithNames -> fetchNativeDrawerAndDirectoryInfos.

Revision Contents
Changeset List

PathSize
keyserver/
src/
6 lines
fetchers/
4 lines
responders/
12 lines
scripts/
4 lines
lib/
actions/
20 lines
reducers/
4 lines
types/
4 lines
3 lines
10 lines
validators/
6 lines
6 lines
native/
components/
8 lines
navigation/
14 lines

Diff 46685

View Options

keyserver/src/endpoints.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

keyserver/src/fetchers/community-fetchers.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

keyserver/src/responders/community-responders.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

keyserver/src/scripts/delete-all-fc-channel-tags.js

This file contains generated code, which does not normally need to be reviewed. Show File Contents
View Options

lib/actions/community-actions.js

Loading...
View Options

lib/reducers/community-reducer.js

Loading...
View Options

lib/types/community-types.js

Loading...
View Options

lib/types/endpoints.js

Loading...
View Options

lib/types/redux-types.js

Loading...
View Options

lib/types/validators/community-validators.js

Loading...
View Options

lib/types/validators/endpoint-validators.js

Loading...
View Options

native/components/display-community-directory-prompt.react.js

Loading...
View Options

native/navigation/community-drawer-content.react.js

Loading...