Details

Reviewers

tomek
ashoat

Commits

rCOMMeec74da2e96b: [services] Backup/Blob - Split aws tools into two tool sets

Summary

Depends on D3913

We can split AwsTools into DynamoDBTools and S3Tools. I did it because the tools for the S3 are only used in the blob service and the tools for dynamo DB are used in both services. Therefore we could move dynamo DB tools to the mutual space.

Test Plan

cd services
yarn run-local-cloud
yarn test-backup-service-dev-mode
yarn test-blob-service-dev-mode

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• karol created this revision.May 6 2022, 6:29 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 6 2022, 6:29 AM

• karol edited the summary of this revision. (Show Details)May 6 2022, 6:33 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D3913: [services] Lib - Move client base reactors.

• karol added a child revision: D3943: [services] Lib - Move dynamo DB tools.

Harbormaster completed remote builds in B8853: Diff 12349.May 6 2022, 6:36 AM

• karol requested review of this revision.May 6 2022, 6:36 AM

• karol planned changes to this revision.May 9 2022, 2:07 AM

update

Harbormaster failed remote builds in B8892: Diff 12396!May 9 2022, 2:11 AM

• karol planned changes to this revision.May 9 2022, 2:23 AM

fix ci

Harbormaster completed remote builds in B8904: Diff 12408.May 9 2022, 2:49 AM

Makes sense to me

This revision is now accepted and ready to land.May 9 2022, 9:10 AM

rebase

Harbormaster completed remote builds in B8957: Diff 12467.May 10 2022, 1:23 AM

Closed by commit rCOMMeec74da2e96b: [services] Backup/Blob - Split aws tools into two tool sets (authored by • karol). · Explain WhyMay 10 2022, 6:39 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMMeec74da2e96b: [services] Backup/Blob - Split aws tools into two tool sets.

[services] Backup/Blob - Split aws tools into two tool sets
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 12509

services/backup/src/AwsTools.h

services/backup/src/AwsTools.cpp

services/backup/src/DatabaseEntities/LogItem.cpp

services/backup/src/DatabaseManager.h

services/backup/src/DynamoDBTools.h

services/backup/src/DynamoDBTools.cpp

services/blob/src/AwsS3Bucket.cpp

services/blob/src/AwsTools.h

services/blob/src/AwsTools.cpp

services/blob/src/BlobServiceImpl.cpp

services/blob/src/DatabaseEntities/BlobItem.cpp

services/blob/src/DatabaseEntities/ReverseIndexItem.cpp

services/blob/src/DatabaseManager.h

services/blob/src/DynamoDBTools.h

services/blob/src/DynamoDBTools.cpp

services/blob/src/Reactors/server/GetReactor.h

services/blob/src/S3Tools.h

services/blob/src/S3Tools.cpp

services/blob/src/Tools.cpp

services/blob/test/MultiPartUploadTest.cpp

services/blob/test/StorageManagerTest.cpp

[services] Backup/Blob - Split aws tools into two tool setsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12509

services/backup/src/AwsTools.h

services/backup/src/AwsTools.cpp

services/backup/src/DatabaseEntities/LogItem.cpp

services/backup/src/DatabaseManager.h

services/backup/src/DynamoDBTools.h

services/backup/src/DynamoDBTools.cpp

services/blob/src/AwsS3Bucket.cpp

services/blob/src/AwsTools.h

services/blob/src/AwsTools.cpp

services/blob/src/BlobServiceImpl.cpp

services/blob/src/DatabaseEntities/BlobItem.cpp

services/blob/src/DatabaseEntities/ReverseIndexItem.cpp

services/blob/src/DatabaseManager.h

services/blob/src/DynamoDBTools.h

services/blob/src/DynamoDBTools.cpp

services/blob/src/Reactors/server/GetReactor.h

services/blob/src/S3Tools.h

services/blob/src/S3Tools.cpp

services/blob/src/Tools.cpp

services/blob/test/MultiPartUploadTest.cpp

services/blob/test/StorageManagerTest.cpp

[services] Backup/Blob - Split aws tools into two tool sets
ClosedPublic
Actions

Revision Contents
Changeset List