Differential D4032

[services] Backup - use generateHolder for new log
ClosedPublic
Actions

Authored by • karol on May 13 2022, 2:27 AM.

Details

Reviewers

tomek

Commits

rCOMM4be789a1a3c6: [services] Backup - use generateHolder for new log

Summary

Depends on D4031

https://linear.app/comm/issue/ENG-1128/implement-generating-holders

Test Plan

Run the blob service
Run the backup service
Use grpc-playground to make a call creating a new backup

See the generated holder in the database or log it out

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• karol created this revision.May 13 2022, 2:27 AM

Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 13 2022, 2:27 AM

• karol edited the summary of this revision. (Show Details)May 13 2022, 2:42 AM

• karol edited the test plan for this revision. (Show Details)

• karol added a reviewer: tomek.

• karol added a parent revision: D4031: [services] Backup - use generateHolder for new backup.

• karol added a child revision: D4033: [services] Move tools to their namespace.

services build passed

Harbormaster completed remote builds in B9083: Diff 12629.May 13 2022, 3:04 AM

tomek accepted this revision.May 17 2022, 3:45 AM

This revision is now accepted and ready to land.May 17 2022, 3:45 AM

tomek requested changes to this revision.May 18 2022, 2:46 AM

tomek added inline comments.

services/backup/src/Reactors/server/SendLogReactor.cpp
111 ↗	(On Diff #12629)	Do we need to update the order here after changes made in D4030?

This revision now requires changes to proceed.May 18 2022, 2:46 AM

• karol added inline comments.May 19 2022, 2:41 AM

services/backup/src/Reactors/server/SendLogReactor.cpp
111 ↗	(On Diff #12629)	Yes, thanks!

fix order

Harbormaster completed remote builds in B9343: Diff 12945.May 19 2022, 5:27 AM

tomek accepted this revision.May 20 2022, 4:25 AM

This revision is now accepted and ready to land.May 20 2022, 4:25 AM

Closed by commit rCOMM4be789a1a3c6: [services] Backup - use generateHolder for new log (authored by • karol). · Explain WhyMay 25 2022, 3:25 AM

This revision was automatically updated to reflect the committed changes.

• karol added a commit: rCOMM4be789a1a3c6: [services] Backup - use generateHolder for new log.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

Reactors/

server/

SendLogReactor.h

4 lines

SendLogReactor.cpp

16 lines

Diff 12945

View Options

services/backup/src/Reactors/server/SendLogReactor.h