Page MenuHomePhabricator

[services] Backup - prevent sending logs for non-existing backups
ClosedPublic

Authored by karol on May 19 2022, 3:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 5, 5:39 AM
Unknown Object (File)
Sun, Jan 5, 5:39 AM
Unknown Object (File)
Wed, Jan 1, 6:46 PM
Unknown Object (File)
Fri, Dec 27, 10:58 AM
Unknown Object (File)
Wed, Dec 25, 5:31 PM
Unknown Object (File)
Fri, Dec 20, 6:37 AM
Unknown Object (File)
Nov 20 2024, 5:00 PM
Unknown Object (File)
Nov 20 2024, 5:00 PM

Details

Summary

Depends on D4074

This is a bug fix. If the backup for the given backup id does not exist in the database, we should abort sending log.

Test Plan
  • terminal 1
cd services
yarn run-blob-service-dev-mode
  • terminal 2
cd services
yarn run-backup-service-dev-mode
  • terminal 3
git clone https://github.com/karol-bisztyga/grpc-playground.git
cd grpc-playground
git checkout backup-async

You can hard-code some fake backup-id in the code (Client.h - lastBackupID)

./build.sh
./cmake/build/bin/client

Then in terminal 3 create a new log

l

With an invalid current backup id, the log cannot be sent.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage