Page MenuHomePhabricator
Differential D4684

[Services] Update generated proto files
ClosedPublic
Actions

Authored by • jon on Jul 29 2022, 2:53 PM.
Tags
None
Referenced Files
F2834141: D4684.diff
Sat, Sep 28, 10:20 AM
Unknown Object (File)
Fri, Sep 27, 4:03 AM
Unknown Object (File)
Fri, Sep 27, 4:03 AM
Unknown Object (File)
Fri, Sep 27, 4:03 AM
Unknown Object (File)
Fri, Sep 27, 4:00 AM
Unknown Object (File)
Tue, Sep 24, 11:22 PM
Unknown Object (File)
Wed, Sep 18, 3:02 PM
Unknown Object (File)
Sun, Sep 1, 12:39 PM
View All Files
Subscribers
• adrian
ashoat
tomek

Details

Reviewers
• karol
• max
atul
• abosh
Commits
rCOMMd839b48b9979: [Services] Update generated proto files
Summary

Needed for blob build to work

just ran cd native && yarn codegen-grpc

Test Plan

Follow test plan for blob diff in stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Jul 29 2022, 2:53 PM
Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptJul 29 2022, 2:53 PM
• jon added a parent revision: D4630: [Services] Install double and folly in base-image.Jul 29 2022, 2:58 PM
• jon added a child revision: D4671: [Services] Update tunnelbroker Dockerfile & cmake.
• jon added a child revision: D4685: [Services] Make build_service.sh PWD independent.Jul 29 2022, 3:00 PM
• jon removed a child revision: D4671: [Services] Update tunnelbroker Dockerfile & cmake.Jul 29 2022, 3:06 PM
Harbormaster completed remote builds in B10981: Diff 15115.Jul 29 2022, 3:06 PM
• jon requested review of this revision.Jul 29 2022, 3:06 PM
• jon added a comment.Aug 1 2022, 11:33 AM

Re-opened https://linear.app/comm/issue/ENG-777 to prevent this in the future

atul added 1 blocking reviewer(s): • karol.Aug 1 2022, 1:20 PM
atul added 1 blocking reviewer(s): • max.
• karol accepted this revision.Aug 2 2022, 2:46 AM
• max accepted this revision.Aug 2 2022, 11:49 AM
This revision is now accepted and ready to land.Aug 2 2022, 11:49 AM
Closed by commit rCOMMd839b48b9979: [Services] Update generated proto files (authored by • jon). · Explain WhyAug 3 2022, 9:27 PM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMMd839b48b9979: [Services] Update generated proto files.

Revision Contents
Changeset List

Diff 15287

View Options

native/cpp/CommonCpp/grpc/_generated/backup.pb.h

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/backup.pb.cc

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.h

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.cc

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.h

Loading...
View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.cc

Loading...