Page MenuHomePhabricator
Differential D5805

[lib] introduce unshimMessageInfo to reaction message spec
ClosedPublic
Actions

Authored by ginsu on Dec 2 2022, 3:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 30, 1:51 PM
Unknown Object (File)
Wed, May 29, 10:57 PM
Unknown Object (File)
Wed, May 29, 9:49 PM
Unknown Object (File)
Wed, May 29, 9:49 PM
Unknown Object (File)
Fri, May 24, 11:35 AM
Unknown Object (File)
Fri, May 24, 11:32 AM
Unknown Object (File)
Sun, May 19, 3:19 PM
Unknown Object (File)
Sun, May 19, 3:19 PM
View All 64 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
rohan
tomek
Commits
rCOMM7890c358db05: [lib] introduce unshimMessageInfo to reaction message spec
Summary

introduce unshimMessageInfo to reaction message spec. unshimMessageInfo handles the unshimming of unsuported messages to a supported message by simply returning the unwrapped messageinfo of the previously unsupported message"

Depends on D5690
Linear Task: ENG-2245

Test Plan

Ran web and mobile app locally and nothing crashes/will be doing more tests on this message spec in subsequent diffs. Also in my local stack, (with some extra code that will come in subsequent diffs) I was able to get a reaction message to "unshim" which I feel is a strong indicator that this function works as expected (see screenshots below)

Reaction Message when unsupported:

Screenshot 2022-11-28 at 11.24.26 AM.png (1×1 px, 826 KB)

Reaction Message when supported:

Screenshot 2022-12-02 at 4.56.02 PM.png (1×1 px, 857 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 2 2022, 3:17 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptDec 2 2022, 3:17 PM
ginsu edited the summary of this revision. (Show Details)Dec 2 2022, 3:22 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, tomek.
ginsu added a parent revision: D5690: [lib] introduced reaction message spec boilerplate.
ginsu attached a referenced file: F270043: Screenshot 2022-12-02 at 4.56.02 PM.png. (Show Details)
ginsu attached a referenced file: F270042: Screenshot 2022-11-28 at 11.24.26 AM.png. (Show Details)
Harbormaster completed remote builds in B13956: Diff 19122.Dec 2 2022, 3:29 PM
ginsu requested review of this revision.Dec 2 2022, 3:29 PM
ginsu added a child revision: D5817: [lib] added reaction type to local unshim types.Dec 5 2022, 7:11 PM
tomek accepted this revision.Dec 6 2022, 6:16 AM
atul accepted this revision.Dec 7 2022, 11:56 AM
This revision is now accepted and ready to land.Dec 7 2022, 11:56 AM
ginsu updated this revision to Diff 19412.Dec 15 2022, 12:09 PM

rebase before landing

Harbormaster completed remote builds in B14189: Diff 19412.Dec 15 2022, 12:22 PM
Closed by commit rCOMM7890c358db05: [lib] introduce unshimMessageInfo to reaction message spec (authored by ginsu). · Explain WhyDec 15 2022, 12:25 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7890c358db05: [lib] introduce unshimMessageInfo to reaction message spec.

Revision Contents
Changeset List

PathSize
lib/
shared/
messages/
4 lines

Diff 19122

View Options

lib/shared/messages/reaction-message-spec.js

Loading...