introduced reactions to chat item height measurer. This is necessary to because in native/chat/message-list-container we measure the messages first and then pass the message list data with heights down to MessageList which will eventually then be used by InlineSidebar
Details
Will be doing more tests in subsequent diffs. Ran mobile/web app locally and nothing crashes. I also was able to get to the point where I could send and reaction and it would render on my local stack (see demo video below)
Also, before these changes I was getting this error message in my logs telling me that the height was incorrect; however, after these changes the error message went away showing that InlineSidebar was taken into consideration
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/chat/chat-item-height-measurer.react.js | ||
---|---|---|
151 ↗ | (On Diff #19152) | How does the measurer know how to measure a reaction? |
native/types/chat-types.js | ||
59 ↗ | (On Diff #19152) | It seems quite extensive to provide the whole list of reactions while the only thing needed for now is a flag telling if there's any reaction, but maybe in the future we would have different height based on number and type of reactions. |
Looks reasonable, adding @ashoat as a blocking reviewer since I don't have much context on NodeHeightMeasurer
- Please respond to my question earlier. It's not clear to me what this diff is doing... is it getting ChatItemHeightMeasurer to measure reactions? Or is it just adding some parameter to fix some Flow issue?
- Can you update the Test Plan to cover making sure that either:
- The measurements are correct (ie. this doesn't trigger on iOS like it does for Android on master, cc @rohan) AND the measurements take InlineSidebar into consideration (looks like they don't?)
- If incorrect measurements don't get caught (eg. the code above is not triggered and/or the measurement's don't take InlineSidebar into consideration), can you make sure that our manual height calculations are still correct?
native/types/chat-types.js | ||
---|---|---|
25 | $ReadOnlyMap |