Page MenuHomePhabricator
Differential D8285

[web] Add `showSpinner` prop to `Avatar` component
ClosedPublic
Actions

Authored by atul on Jun 21 2023, 3:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 23 2024, 1:52 PM
Unknown Object (File)
Nov 23 2024, 1:52 PM
Unknown Object (File)
Nov 23 2024, 1:51 PM
Unknown Object (File)
Nov 23 2024, 1:51 PM
Unknown Object (File)
Nov 23 2024, 1:51 PM
Unknown Object (File)
Nov 9 2024, 9:31 PM
Unknown Object (File)
Nov 9 2024, 7:25 PM
Unknown Object (File)
Nov 9 2024, 4:23 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
rohan
Commits
rCOMM0bf79d623ea4: [web] Add `showSpinner` prop to `Avatar` component
Summary

Add showSpinner?: boolean prop to the Avatar component and display LoadingIndicator over Avatar if set to true.

Depends on D8283

Test Plan

Looks as expected:

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 21 2023, 3:24 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 3:24 PM
atul published this revision for review.Jun 21 2023, 3:26 PM
atul edited the test plan for this revision. (Show Details)
atul added inline comments.Jun 21 2023, 3:29 PM
web/avatars/avatar.react.js
68–77

Made sure things looked okay at each size:

c6c316.png (102×142 px, 9 KB)

fce579.png (74×70 px, 6 KB)

e3c706.png (58×98 px, 5 KB)

4e0a45.png (256×314 px, 38 KB)

atul attached a referenced file: F600891: 4e0a45.png. (Show Details)Jun 21 2023, 3:29 PM
atul attached a referenced file: F600890: e3c706.png. (Show Details)
atul attached a referenced file: F600889: fce579.png. (Show Details)
atul attached a referenced file: F600888: c6c316.png. (Show Details)
atul added a child revision: D8286: [web] Remove `LoadingIndicator` from `EditUserAvatar`.Jun 21 2023, 3:39 PM
Harbormaster completed remote builds in B20412: Diff 27984.Jun 21 2023, 3:47 PM
rohan accepted this revision.Jun 22 2023, 6:29 AM
This revision is now accepted and ready to land.Jun 22 2023, 6:29 AM
atul updated this revision to Diff 28081.Jun 23 2023, 1:56 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 23 2023, 2:07 PM
Closed by commit rCOMM0bf79d623ea4: [web] Add `showSpinner` prop to `Avatar` component (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM0bf79d623ea4: [web] Add `showSpinner` prop to `Avatar` component.
Harbormaster completed remote builds in B20495: Diff 28081.Jun 23 2023, 2:41 PM

Revision Contents
Changeset List

PathSize
web/
avatars/
11 lines
31 lines
6 lines

Diff 27984

View Options

web/avatars/avatar.css

Loading...
View Options

web/avatars/avatar.react.js

Loading...
View Options

web/avatars/emoji-avatar-selection-modal.react.js

Loading...