Details

Reviewers

ashoat
ginsu
rohan

Commits

rCOMM0bf79d623ea4: [web] Add `showSpinner` prop to `Avatar` component

Summary

Add showSpinner?: boolean prop to the Avatar component and display LoadingIndicator over Avatar if set to true.

Depends on D8283

Test Plan

Looks as expected:

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 21 2023, 10:24 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 21 2023, 10:24 PM

atul published this revision for review.Jun 21 2023, 10:26 PM

atul edited the test plan for this revision. (Show Details)

atul added inline comments.Jun 21 2023, 10:29 PM

web/avatars/avatar.react.js
68–77 ↗	(On Diff #27984)	Made sure things looked okay at each size:

atul attached a referenced file: F600891: 4e0a45.png. (Show Details)Jun 21 2023, 10:29 PM

atul attached a referenced file: F600890: e3c706.png. (Show Details)

atul attached a referenced file: F600889: fce579.png. (Show Details)

atul attached a referenced file: F600888: c6c316.png. (Show Details)

atul added a child revision: D8286: [web] Remove `LoadingIndicator` from `EditUserAvatar`.Jun 21 2023, 10:39 PM

Harbormaster completed remote builds in B20412: Diff 27984.Jun 21 2023, 10:47 PM

rohan accepted this revision.Jun 22 2023, 1:29 PM

This revision is now accepted and ready to land.Jun 22 2023, 1:29 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jun 23 2023, 9:07 PM

Closed by commit rCOMM0bf79d623ea4: [web] Add `showSpinner` prop to `Avatar` component. · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM0bf79d623ea4: [web] Add `showSpinner` prop to `Avatar` component.

Harbormaster completed remote builds in B20495: Diff 28081.Jun 23 2023, 9:41 PM

[web] Add `showSpinner` prop to `Avatar` component
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 28095

web/avatars/avatar.css

web/avatars/avatar.react.js

web/avatars/emoji-avatar-selection-modal.react.js

[web] Add `showSpinner` prop to `Avatar` componentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28095

web/avatars/avatar.css

web/avatars/avatar.react.js

web/avatars/emoji-avatar-selection-modal.react.js

[web] Add `showSpinner` prop to `Avatar` component
ClosedPublic
Actions

Revision Contents
Changeset List