Base]EditUserAvatarProvider` into `BaseEditUserAvatarProvider`
ClosedPublic
Actions

Authored by atul on Jun 27 2023, 6:25 PM.

Details

Reviewers

ashoat
ginsu
rohan

Commits

rCOMM31b86cdab53a: Consolidate `[Web/Native/Base]EditUserAvatarProvider` into…

Summary

As of this diff all of the platform-specific functionality has been moved out of BaseEditUserAvatarProvider, which allows us to consolidate the three previous providers into one.

This concludes most of the refactoring work aimed at decoupling avatar-hooks and *AvatarProviders.

Next diff will involve renaming BaseEditUserAvatarProvider to EditUserAvatarProvider (was initially supposed to be part of this diff, but all the import changes and whatnot made it messy)

Depends on D8346

Test Plan

Still able to update avatars as expected on both native and web.

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D8347 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 27 2023, 6:25 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 6:25 PM

atul published this revision for review.Jun 27 2023, 6:27 PM

atul retitled this revision from Consolidate `[Web/Native/Base]EditUserAvatarProvider` into `EditUserAvatarProvider` to Consolidate `[Web/Native/Base]EditUserAvatarProvider` into `BaseEditUserAvatarProvider`.

atul edited the summary of this revision. (Show Details)

atul added a child revision: D8348: Rename `BaseEditUserAvatarProvider` to `EditUserAvatarProvider`.Jun 27 2023, 6:29 PM

Harbormaster completed remote builds in B20565: Diff 28200.Jun 27 2023, 6:43 PM

rohan accepted this revision.Jun 28 2023, 10:13 AM

rohan added inline comments.