[native] Make metadata related methods public
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 3:15 AM.

Details

Reviewers

michal
tomek
• jon

Commits

rCOMM5464404e0f7c: [native] Make metadata related methods public

Summary

On web those methods are used directly, to add emscripten binding methods have to be public.

Depends on D8548

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Branch

wasm-publish

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 19 2023, 3:15 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 3:15 AM

Harbormaster completed remote builds in B21025: Diff 28820.Jul 19 2023, 3:32 AM

kamil added a child revision: D8550: [native] hide native-specific code.Jul 19 2023, 5:33 AM

kamil published this revision for review.Jul 19 2023, 8:59 AM

• jon accepted this revision.Jul 19 2023, 12:06 PM

This revision is now accepted and ready to land.Jul 19 2023, 12:06 PM

Closed by commit rCOMM5464404e0f7c: [native] Make metadata related methods public (authored by kamil). · Explain WhyJul 27 2023, 5:06 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM5464404e0f7c: [native] Make metadata related methods public.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

7 lines

SQLiteQueryExecutor.h

6 lines

Diff 28820

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h