Page MenuHomePhabricator
Differential D9319

[lib] Move message update reducer into specs
ClosedPublic
Actions

Authored by tomek on Sep 28 2023, 8:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 10:47 AM
Unknown Object (File)
Tue, Jan 28, 7:50 PM
Unknown Object (File)
Mon, Jan 27, 7:41 PM
Unknown Object (File)
Mon, Jan 20, 4:34 PM
Unknown Object (File)
Mon, Jan 20, 4:34 PM
Unknown Object (File)
Mon, Jan 20, 4:34 PM
Unknown Object (File)
Mon, Jan 20, 4:22 PM
Unknown Object (File)
Jan 6 2025, 10:44 PM
View All 96 Files
Subscribers
ashoat
michal

Details

Reviewers
kamil
bartek
inka
Commits
rCOMM6b2c387d34e2: [lib] Move message update reducer into specs
Summary

Use a similar approach to the original one, which is based on mutating the result while iterating the array.

Depends on D9318

https://linear.app/comm/issue/ENG-4241/handle-processupdatesactiontype-as-a-part-of-a-spec

Test Plan

Check if the new code produces the same result os the old one.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
reducers/
31 lines
shared/
updates/
25 lines
11 lines

Diff 31782

View Options

lib/reducers/message-reducer.js

Loading...
View Options

lib/shared/updates/join-thread-spec.js

Loading...
View Options

lib/shared/updates/update-spec.js

Loading...