[lib][web][native] Refactor actions in message-report-actions.js
ClosedPublic
Actions

Authored by inka on Oct 5 2023, 5:54 AM.

Details

Reviewers

michal
kamil
ginsu

Commits

rCOMMcf28f6074871: [lib][web][native] Refactor actions in message-report-actions.js

Summary

issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions

Test Plan

Tested that the actions work as expected

Diff Detail

Repository

rCOMM Comm

Branch

inka/actions_new_branch

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Oct 5 2023, 5:54 AM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 5 2023, 5:54 AM

Harbormaster completed remote builds in B23002: Diff 31682.Oct 5 2023, 6:12 AM

inka requested review of this revision.Oct 5 2023, 6:12 AM

inka added a parent revision: D9368: [lib][web][native] Refactor actions in link-actions.js.Oct 5 2023, 6:19 AM

Retry

Harbormaster completed remote builds in B23003: Diff 31683.Oct 5 2023, 6:46 AM

inka added a child revision: D9370: [lib][web][native] Refactor actions in thread-actions.js pt.1.Oct 5 2023, 9:02 AM

michal accepted this revision.Oct 11 2023, 1:21 AM

michal added inline comments.

lib/actions/message-report-actions.js
27	We shouldn't hide await inside of an another expression

This revision is now accepted and ready to land.Oct 11 2023, 1:21 AM

Address review

Harbormaster completed remote builds in B23677: Diff 32631.Nov 2 2023, 10:45 AM

Closed by commit rCOMMcf28f6074871: [lib][web][native] Refactor actions in message-report-actions.js (authored by inka). · Explain WhyNov 6 2023, 5:45 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMMcf28f6074871: [lib][web][native] Refactor actions in message-report-actions.js.

Revision Contents
Changeset List

Path

Size

lib/

actions/

message-report-actions.js

27 lines

native/

chat/

message-report-utils.js

9 lines

Diff 31683

View Options

lib/actions/message-report-actions.js