Paths

Table of Contentst

[web] update web avatars to use t shirt sizes
ClosedPublic
Actions

Authored by ginsu on Oct 8 2023, 11:23 PM.

Details

Reviewers

atul
inka

Commits

rCOMMbf1e34799dcd: [web] update web avatars to use t shirt sizes

Summary

In D9364 we updated the sizing type for the native avatar component to be t-shirt sizes. We should do the same for the web avatar component

https://linear.app/comm/issue/ENG-4961/introduce-profilelarge-avatar-size-variant

Test Plan

flow and confirmed that there were no regressions with avatars

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 8 2023, 11:23 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 8 2023, 11:23 PM

ginsu edited the summary of this revision. (Show Details)Oct 8 2023, 11:25 PM

ginsu added reviewers: atul, inka.

ginsu added a child revision: D9408: [web] introduce XL and XXL sizes to the avatar component.Oct 8 2023, 11:29 PM

Harbormaster completed remote builds in B23074: Diff 31767.Oct 8 2023, 11:41 PM

ginsu requested review of this revision.Oct 8 2023, 11:41 PM

Skimmed this very briefly, counting on CI/flow/etc

This revision is now accepted and ready to land.Oct 9 2023, 1:46 PM

rebase before landing

Harbormaster completed remote builds in B23268: Diff 32045.Oct 16 2023, 10:03 PM

Closed by commit rCOMMbf1e34799dcd: [web] update web avatars to use t shirt sizes (authored by ginsu). · Explain WhyOct 16 2023, 10:58 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMbf1e34799dcd: [web] update web avatars to use t shirt sizes.

Revision Contents
Changeset List

Path

Size

web/

avatars/

avatar.css

12 lines

avatar.react.js

29 lines

edit-thread-avatar.react.js

2 lines

edit-user-avatar.react.js

2 lines

emoji-avatar-selection-modal.react.js

2 lines

thread-avatar.react.js

3 lines

user-avatar.react.js

3 lines

chat/

chat-thread-composer.react.js

2 lines

chat-thread-list-item.react.js

2 lines

composed-message.react.js

2 lines

thread-top-bar.react.js

2 lines

modals/

chat/

message-reactions-modal.react.js

2 lines

components/

add-members-item.react.js

2 lines

threads/

members/

change-member-role-modal.react.js

2 lines

member.react.js

2 lines

sidebars/

sidebar.react.js

2 lines

subchannels/

subchannel.react.js

2 lines

thread-picker-modal.react.js

2 lines

navigation-panels/

nav-state-info-bar.react.js

2 lines

settings/

relationship/

block-list-row.react.js

2 lines

friend-list-row.react.js

2 lines

sidebar/

community-creation/

community-creation-modal.react.js

2 lines

community-drawer-item-community.react.js

2 lines

community-drawer-item.react.js

2 lines

utils/

typeahead-utils.js

7 lines

Diff 32059

View Options

web/avatars/avatar.css

View Options

web/avatars/avatar.react.js

View Options

web/avatars/edit-thread-avatar.react.js

View Options

web/avatars/edit-user-avatar.react.js

View Options

web/avatars/emoji-avatar-selection-modal.react.js

View Options

web/avatars/thread-avatar.react.js

View Options

web/avatars/user-avatar.react.js

View Options

web/chat/chat-thread-composer.react.js

View Options

web/chat/chat-thread-list-item.react.js

View Options

web/chat/composed-message.react.js

View Options

web/chat/thread-top-bar.react.js

View Options

web/modals/chat/message-reactions-modal.react.js

View Options

web/modals/components/add-members-item.react.js

View Options

web/modals/threads/members/change-member-role-modal.react.js

View Options

web/modals/threads/members/member.react.js

View Options

web/modals/threads/sidebars/sidebar.react.js

View Options

web/modals/threads/subchannels/subchannel.react.js

View Options

web/modals/threads/thread-picker-modal.react.js

View Options

web/navigation-panels/nav-state-info-bar.react.js

View Options

web/settings/relationship/block-list-row.react.js

View Options

web/settings/relationship/friend-list-row.react.js

View Options

web/sidebar/community-creation/community-creation-modal.react.js

View Options

web/sidebar/community-drawer-item-community.react.js

View Options

web/sidebar/community-drawer-item.react.js

View Options

web/utils/typeahead-utils.js

[web] update web avatars to use t shirt sizesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32059

web/avatars/avatar.css

web/avatars/avatar.react.js

web/avatars/edit-thread-avatar.react.js

web/avatars/edit-user-avatar.react.js

web/avatars/emoji-avatar-selection-modal.react.js

web/avatars/thread-avatar.react.js

web/avatars/user-avatar.react.js

web/chat/chat-thread-composer.react.js

web/chat/chat-thread-list-item.react.js

web/chat/composed-message.react.js

web/chat/thread-top-bar.react.js

web/modals/chat/message-reactions-modal.react.js

web/modals/components/add-members-item.react.js

web/modals/threads/members/change-member-role-modal.react.js

web/modals/threads/members/member.react.js

web/modals/threads/sidebars/sidebar.react.js

web/modals/threads/subchannels/subchannel.react.js

web/modals/threads/thread-picker-modal.react.js

web/navigation-panels/nav-state-info-bar.react.js

web/settings/relationship/block-list-row.react.js

web/settings/relationship/friend-list-row.react.js

web/sidebar/community-creation/community-creation-modal.react.js

web/sidebar/community-drawer-item-community.react.js

web/sidebar/community-drawer-item.react.js

web/utils/typeahead-utils.js

[web] update web avatars to use t shirt sizes
ClosedPublic
Actions

Revision Contents
Changeset List