[lib] Move transforming rows into updates to specs
ClosedPublic
Actions

Authored by tomek on Oct 10 2023, 12:34 PM.

Details

Reviewers

kamil
bartek
inka

Commits

rCOMM38b0a18c117f: [lib] Move transforming rows into updates to specs

Summary

Move the logic into specs.

https://linear.app/comm/issue/ENG-4238/use-specs-in-update-fetchers

Test Plan

Generate some updates and check if they are fetched from the db.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Oct 10 2023, 12:34 PM

Herald added subscribers: will, ashoat. · View Herald TranscriptOct 10 2023, 12:34 PM

Delete FlowFixMe

Harbormaster completed remote builds in B23139: Diff 31858.Oct 10 2023, 12:54 PM

Harbormaster completed remote builds in B23140: Diff 31859.Oct 10 2023, 1:05 PM

tomek requested review of this revision.Oct 10 2023, 1:05 PM

bartek accepted this revision.Oct 12 2023, 6:20 AM

This revision is now accepted and ready to land.Oct 12 2023, 6:20 AM

tomek added a child revision: D9653: [keyserver] Move DB update content generation into specs.Oct 31 2023, 3:34 PM

Closed by commit rCOMM38b0a18c117f: [lib] Move transforming rows into updates to specs. · Explain WhyNov 6 2023, 2:58 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM38b0a18c117f: [lib] Move transforming rows into updates to specs.

tomek added a parent revision: D9354: [lib] Move inconsistencies finding into specs.Apr 10 2024, 12:15 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

update-fetchers.js

79 lines

lib/

shared/

updates/

bad-device-token-spec.js

22 lines

delete-account-spec.js

89 lines

delete-thread-spec.js

73 lines

join-thread-spec.js

20 lines

update-current-user-spec.js

33 lines

update-entry-spec.js

46 lines

update-spec.js

8 lines

update-specs.js

2 lines

update-thread-read-status-spec.js

76 lines

update-thread-spec.js

20 lines

update-user-spec.js

19 lines

types/

update-types.js

18 lines

Diff 32771

View Options

keyserver/src/fetchers/update-fetchers.js

View Options

lib/shared/updates/bad-device-token-spec.js

View Options

lib/shared/updates/delete-account-spec.js

View Options

lib/shared/updates/delete-thread-spec.js

View Options

lib/shared/updates/join-thread-spec.js

View Options

lib/shared/updates/update-current-user-spec.js

View Options

lib/shared/updates/update-entry-spec.js

View Options

lib/shared/updates/update-spec.js

View Options

lib/shared/updates/update-specs.js

View Options

lib/shared/updates/update-thread-read-status-spec.js

View Options

lib/shared/updates/update-thread-spec.js

View Options

lib/shared/updates/update-user-spec.js

View Options

[lib] Move transforming rows into updates to specsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 32771

keyserver/src/fetchers/update-fetchers.js

lib/shared/updates/bad-device-token-spec.js

lib/shared/updates/delete-account-spec.js

lib/shared/updates/delete-thread-spec.js

lib/shared/updates/join-thread-spec.js

lib/shared/updates/update-current-user-spec.js

lib/shared/updates/update-entry-spec.js

lib/shared/updates/update-spec.js

lib/shared/updates/update-specs.js

lib/shared/updates/update-thread-read-status-spec.js

lib/shared/updates/update-thread-spec.js

lib/shared/updates/update-user-spec.js

lib/types/update-types.js

[lib] Move transforming rows into updates to specs
ClosedPublic
Actions

Revision Contents
Changeset List