Page MenuHomePhabricator

[Tunnelbroker] add recipient confirmation to Tunnelbroker
ClosedPublic

Authored by kamil on Oct 24 2023, 10:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 10:01 AM
Unknown Object (File)
Sat, Nov 9, 9:42 AM
Unknown Object (File)
Sat, Nov 9, 4:45 AM
Unknown Object (File)
Nov 2 2024, 5:31 AM
Unknown Object (File)
Nov 2 2024, 5:30 AM
Unknown Object (File)
Nov 2 2024, 5:30 AM
Unknown Object (File)
Nov 2 2024, 5:11 AM
Unknown Object (File)
Oct 18 2024, 9:02 PM
Subscribers

Details

Summary

We should delete message from DDB after making sure that it was delivered and processed by recipient.

Depends on D9575

Test Plan
  1. All Tunnelbroker tests passed
  2. Empty DDB after tests (confirmation is processed by Tunnelbroker)
  3. Tests exclusively for recipient confirmation in next diff

Diff Detail

Repository
rCOMM Comm
Branch
recipient-confirmation
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Oct 24 2023, 11:21 AM
kamil added inline comments.
services/commtest/tests/identity_tunnelbroker_tests.rs
95

I checked in the Identity logs, and it's true that this message was sent twice to the WebSocket (cc. @varun).

services/tunnelbroker/src/websockets/mod.rs
198–203

This way you can avoid unwrapping

services/tunnelbroker/src/websockets/session.rs
245–253

In the future we should do a batch delete operation here. We should have a follow up task for this. There are utilities in comm-services-lib for this but Tunnelbroker isn't using it yet.

services/tunnelbroker/src/websockets/mod.rs
198–203

nice! thanks

services/tunnelbroker/src/websockets/session.rs
245–253

created ENG-5627

this will also require ENG-5172 - otherwise doesn't make a lot of sense

This revision is now accepted and ready to land.Nov 2 2023, 5:59 AM