Page MenuHomePhabricator
Differential D9644

[lib] Add function for splitting calendar query per keyserver
ClosedPublic
Actions

Authored by inka on Oct 31 2023, 2:48 AM.
Tags
None
Referenced Files
F3181063: D9644.diff
Fri, Nov 8, 5:25 AM
Unknown Object (File)
Sun, Oct 27, 9:47 PM
Unknown Object (File)
Sun, Oct 27, 9:47 PM
Unknown Object (File)
Sun, Oct 27, 9:47 PM
Unknown Object (File)
Sun, Oct 27, 9:36 PM
Unknown Object (File)
Thu, Oct 24, 1:46 PM
Unknown Object (File)
Oct 3 2024, 1:15 AM
Unknown Object (File)
Sep 29 2024, 2:57 PM
View All 86 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMMaaabc2dd1277: [lib] Add function for splitting calendar query per keyserver
Summary

issue: https://linear.app/comm/issue/ENG-5283/refactor-login-action
Calendar query inclued filters, that may include an array of threads. We don't want to send the ids of threads of one keyserver to a different keyserver, so we need a way to split them. We want the queries to stay otherwise the same for all keyservers

Test Plan

Run the provided test

Diff Detail

Repository
rCOMM Comm
Branch
inka/actions_new_branch
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 31 2023, 2:48 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 31 2023, 2:48 AM
inka added a parent revision: D9640: [keyserver][lib] Remove id from LoggedOutUserInfo.Oct 31 2023, 2:49 AM
inka edited parent revisions, added: D9645: [lib][web][native] Refactor actions in user-actions.js pt.2; removed: D9640: [keyserver][lib] Remove id from LoggedOutUserInfo.Oct 31 2023, 2:51 AM
Harbormaster completed remote builds in B23587: Diff 32523.Oct 31 2023, 3:06 AM
inka requested review of this revision.Oct 31 2023, 3:06 AM
inka planned changes to this revision.Oct 31 2023, 4:33 AM
inka updated this revision to Diff 32530.Oct 31 2023, 4:49 AM

Update function to handle the case when no thread filter provided

Harbormaster completed remote builds in B23589: Diff 32530.Oct 31 2023, 5:07 AM
inka removed a parent revision: D9645: [lib][web][native] Refactor actions in user-actions.js pt.2.Nov 2 2023, 6:42 AM
inka added a child revision: D9356: [lib][web][native] Refactor actions in entry-actions.js.
inka added a parent revision: D9353: [lib] Refactor actions in activity-actions.js.
michal accepted this revision.Nov 3 2023, 5:13 AM
This revision is now accepted and ready to land.Nov 3 2023, 5:13 AM
Closed by commit rCOMMaaabc2dd1277: [lib] Add function for splitting calendar query per keyserver (authored by inka). · Explain WhyNov 6 2023, 5:44 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMaaabc2dd1277: [lib] Add function for splitting calendar query per keyserver.

Revision Contents
Changeset List

PathSize
lib/
utils/
48 lines
74 lines

Diff 32530

View Options

lib/utils/action-utils.js

Loading...
View Options

lib/utils/action-utils.test.js

Loading...