Page MenuHomePhabricator
Differential D9650

[keyserver][web] Refactor getInitialReduxState action
ClosedPublic
Actions

Authored by inka on Oct 31 2023, 7:05 AM.
Tags
None
Referenced Files
F3181143: D9650.diff
Fri, Nov 8, 5:34 AM
Unknown Object (File)
Sat, Nov 2, 6:53 AM
Unknown Object (File)
Sat, Nov 2, 6:53 AM
Unknown Object (File)
Sat, Nov 2, 6:52 AM
Unknown Object (File)
Sat, Nov 2, 6:52 AM
Unknown Object (File)
Sat, Nov 2, 6:51 AM
Unknown Object (File)
Sat, Nov 2, 6:51 AM
Unknown Object (File)
Sat, Nov 2, 6:30 AM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM967c0c0e3995: [keyserver][web] Refactor getInitialReduxState action
Summary

issue: https://linear.app/comm/issue/ENG-5181/refactor-getinitialreduxstate-action

Test Plan

Checked that the value returned by this action is correct, chekced that the app loads without errors

Diff Detail

Repository
rCOMM Comm
Branch
inka/actions_new_branch
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 31 2023, 7:05 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 31 2023, 7:05 AM
inka added a parent revision: D9648: [lib][web][native] Refactor actions in user-actions.js pt.3 - login.Oct 31 2023, 7:06 AM
Harbormaster completed remote builds in B23600: Diff 32543.Oct 31 2023, 7:26 AM
inka requested review of this revision.Oct 31 2023, 7:26 AM
ashoat added inline comments.Nov 1 2023, 7:02 AM
web/types/redux-types.js
36 ↗(On Diff #32543)

Should this be read-only?

inka updated this revision to Diff 32645.Nov 2 2023, 12:05 PM

Make type read only

Harbormaster completed remote builds in B23691: Diff 32645.Nov 2 2023, 1:09 PM
michal added inline comments.Nov 3 2023, 7:57 AM
web/redux/action-types.js
29

URLInfo contains thread which should be separated per keyserver

inka updated this revision to Diff 32755.Nov 6 2023, 5:37 AM

Address review

Harbormaster completed remote builds in B23787: Diff 32755.Nov 6 2023, 5:57 AM
michal added a comment.Nov 7 2023, 2:44 AM

We might also want to remove invite secret from urlinfo

inka updated this revision to Diff 32850.Nov 7 2023, 3:46 AM

Stop sending inviteSecret to keyservers. I tested that the invite links still work correctly

michal accepted this revision.Nov 7 2023, 3:46 AM
This revision is now accepted and ready to land.Nov 7 2023, 3:46 AM
Harbormaster failed remote builds in B23833: Diff 32850!Nov 7 2023, 4:03 AM
This revision was landed with ongoing or failed builds.Nov 7 2023, 6:35 AM
Closed by commit rCOMM967c0c0e3995: [keyserver][web] Refactor getInitialReduxState action (authored by inka). · Explain Why
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM967c0c0e3995: [keyserver][web] Refactor getInitialReduxState action.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
19 lines
web/
redux/
142 lines
8 lines
17 lines
types/
19 lines

Diff 32645

View Options

keyserver/src/responders/redux-state-responders.js

Loading...
View Options

web/redux/action-types.js

Loading...
View Options

web/redux/initial-state-gate.js

Loading...
View Options

web/redux/redux-setup.js

Loading...
View Options

web/types/redux-types.js

Loading...