Page MenuHomePhabricator
Differential D9654

[keyserver] Determine which entities to fetch in a spec
ClosedPublic
Actions

Authored by tomek on Oct 31 2023, 8:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 3:39 PM
Unknown Object (File)
Thu, Apr 17, 2:27 PM
Unknown Object (File)
Thu, Apr 17, 9:08 AM
Unknown Object (File)
Tue, Apr 15, 9:04 PM
Unknown Object (File)
Wed, Apr 9, 10:55 PM
Unknown Object (File)
Wed, Apr 9, 11:32 AM
Unknown Object (File)
Tue, Apr 8, 11:26 AM
Unknown Object (File)
Mar 21 2025, 1:26 AM
View All 73 Files
Subscribers
ashoat
will

Details

Reviewers
kamil
inka
bartek
Commits
rCOMM1af48b185e92: [keyserver] Determine which entities to fetch in a spec
Summary

Add a function to a spec which determines which threads, entries, etc. need to be fetched.

Depends on D9653

Test Plan

Generate some updates, reintroduce old code, and compare new with old result using _.isEqual

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
41 lines
lib/
shared/
updates/
6 lines
5 lines
5 lines
6 lines
5 lines

Diff 32552

View Options

keyserver/src/creators/update-creator.js

// @flow // @flow
import html from 'common-tags/lib/html/index.js'; import html from 'common-tags/lib/html/index.js';
import { detect as detectBrowser } from 'detect-browser'; import { detect as detectBrowser } from 'detect-browser';
import type { $Response, $Request } from 'express'; import type { $Response, $Request } from 'express';
import fs from 'fs'; import fs from 'fs';
import _isEqual from 'lodash/fp/isEqual.js'; import _isEqual from 'lodash/fp/isEqual.js';
import _keyBy from 'lodash/fp/keyBy.js'; import _keyBy from 'lodash/fp/keyBy.js';
import * as React from 'react'; import * as React from 'react';
// eslint-disable-next-line import/extensions // eslint-disable-next-line import/extensions
import ReactDOMServer from 'react-dom/server'; import ReactDOMServer from 'react-dom/server';
import t from 'tcomb'; import t from 'tcomb';
import { promisify } from 'util'; import { promisify } from 'util';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { baseLegalPolicies } from 'lib/facts/policies.js'; import { baseLegalPolicies } from 'lib/facts/policies.js';
import stores from 'lib/facts/stores.js'; import stores from 'lib/facts/stores.js';
import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js'; import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js';
import { freshMessageStore } from 'lib/reducers/message-reducer.js'; import { freshMessageStore } from 'lib/reducers/message-reducer.js';
import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js'; import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js';
import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js'; import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js';
import { import {
threadHasPermission, threadHasPermission,
▲ Show 20 Lines • Show All 775 Lines • ▼ Show 20 Lines <html lang="en">
</section> </section>
<p> <p>
To join this community, download the Comm app and reopen this invite To join this community, download the Comm app and reopen this invite
link link
</p> </p>
<div class="separator"></div> <div class="separator"></div>
<section class="buttons"> <section class="buttons">
<a class="button" href="${stores.appStoreUrl}">Download Comm</a> <a class="button" href="${stores.appStoreUrl}">Download Comm</a>
<a class="button secondary" href="${inviteLinkUrl(secret)}"> <a class="button secondary" href="${inviteLinkURL(secret)}">
Invite Link Invite Link
</a> </a>
</section> </section>
</section> </section>
<a class="link" href="https://comm.app/"> <a class="link" href="https://comm.app/">
<span class="link-text">Visit Comm’s website</span> <span class="link-text">Visit Comm’s website</span>
<img <img
src="/images/arrow_up_right.svg" src="/images/arrow_up_right.svg"
Show All 10 Lines
View Options

lib/shared/updates/join-thread-spec.js

// @flow // @flow
import html from 'common-tags/lib/html/index.js'; import html from 'common-tags/lib/html/index.js';
import { detect as detectBrowser } from 'detect-browser'; import { detect as detectBrowser } from 'detect-browser';
import type { $Response, $Request } from 'express'; import type { $Response, $Request } from 'express';
import fs from 'fs'; import fs from 'fs';
import _isEqual from 'lodash/fp/isEqual.js'; import _isEqual from 'lodash/fp/isEqual.js';
import _keyBy from 'lodash/fp/keyBy.js'; import _keyBy from 'lodash/fp/keyBy.js';
import * as React from 'react'; import * as React from 'react';
// eslint-disable-next-line import/extensions // eslint-disable-next-line import/extensions
import ReactDOMServer from 'react-dom/server'; import ReactDOMServer from 'react-dom/server';
import t from 'tcomb'; import t from 'tcomb';
import { promisify } from 'util'; import { promisify } from 'util';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { baseLegalPolicies } from 'lib/facts/policies.js'; import { baseLegalPolicies } from 'lib/facts/policies.js';
import stores from 'lib/facts/stores.js'; import stores from 'lib/facts/stores.js';
import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js'; import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js';
import { freshMessageStore } from 'lib/reducers/message-reducer.js'; import { freshMessageStore } from 'lib/reducers/message-reducer.js';
import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js'; import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js';
import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js'; import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js';
import { import {
threadHasPermission, threadHasPermission,
▲ Show 20 Lines • Show All 775 Lines • ▼ Show 20 Lines <html lang="en">
</section> </section>
<p> <p>
To join this community, download the Comm app and reopen this invite To join this community, download the Comm app and reopen this invite
link link
</p> </p>
<div class="separator"></div> <div class="separator"></div>
<section class="buttons"> <section class="buttons">
<a class="button" href="${stores.appStoreUrl}">Download Comm</a> <a class="button" href="${stores.appStoreUrl}">Download Comm</a>
<a class="button secondary" href="${inviteLinkUrl(secret)}"> <a class="button secondary" href="${inviteLinkURL(secret)}">
Invite Link Invite Link
</a> </a>
</section> </section>
</section> </section>
<a class="link" href="https://comm.app/"> <a class="link" href="https://comm.app/">
<span class="link-text">Visit Comm’s website</span> <span class="link-text">Visit Comm’s website</span>
<img <img
src="/images/arrow_up_right.svg" src="/images/arrow_up_right.svg"
Show All 10 Lines
View Options

lib/shared/updates/update-current-user-spec.js

// @flow // @flow
import html from 'common-tags/lib/html/index.js'; import html from 'common-tags/lib/html/index.js';
import { detect as detectBrowser } from 'detect-browser'; import { detect as detectBrowser } from 'detect-browser';
import type { $Response, $Request } from 'express'; import type { $Response, $Request } from 'express';
import fs from 'fs'; import fs from 'fs';
import _isEqual from 'lodash/fp/isEqual.js'; import _isEqual from 'lodash/fp/isEqual.js';
import _keyBy from 'lodash/fp/keyBy.js'; import _keyBy from 'lodash/fp/keyBy.js';
import * as React from 'react'; import * as React from 'react';
// eslint-disable-next-line import/extensions // eslint-disable-next-line import/extensions
import ReactDOMServer from 'react-dom/server'; import ReactDOMServer from 'react-dom/server';
import t from 'tcomb'; import t from 'tcomb';
import { promisify } from 'util'; import { promisify } from 'util';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { baseLegalPolicies } from 'lib/facts/policies.js'; import { baseLegalPolicies } from 'lib/facts/policies.js';
import stores from 'lib/facts/stores.js'; import stores from 'lib/facts/stores.js';
import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js'; import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js';
import { freshMessageStore } from 'lib/reducers/message-reducer.js'; import { freshMessageStore } from 'lib/reducers/message-reducer.js';
import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js'; import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js';
import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js'; import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js';
import { import {
threadHasPermission, threadHasPermission,
▲ Show 20 Lines • Show All 775 Lines • ▼ Show 20 Lines <html lang="en">
</section> </section>
<p> <p>
To join this community, download the Comm app and reopen this invite To join this community, download the Comm app and reopen this invite
link link
</p> </p>
<div class="separator"></div> <div class="separator"></div>
<section class="buttons"> <section class="buttons">
<a class="button" href="${stores.appStoreUrl}">Download Comm</a> <a class="button" href="${stores.appStoreUrl}">Download Comm</a>
<a class="button secondary" href="${inviteLinkUrl(secret)}"> <a class="button secondary" href="${inviteLinkURL(secret)}">
Invite Link Invite Link
</a> </a>
</section> </section>
</section> </section>
<a class="link" href="https://comm.app/"> <a class="link" href="https://comm.app/">
<span class="link-text">Visit Comm’s website</span> <span class="link-text">Visit Comm’s website</span>
<img <img
src="/images/arrow_up_right.svg" src="/images/arrow_up_right.svg"
Show All 10 Lines
View Options

lib/shared/updates/update-entry-spec.js

// @flow // @flow
import html from 'common-tags/lib/html/index.js'; import html from 'common-tags/lib/html/index.js';
import { detect as detectBrowser } from 'detect-browser'; import { detect as detectBrowser } from 'detect-browser';
import type { $Response, $Request } from 'express'; import type { $Response, $Request } from 'express';
import fs from 'fs'; import fs from 'fs';
import _isEqual from 'lodash/fp/isEqual.js'; import _isEqual from 'lodash/fp/isEqual.js';
import _keyBy from 'lodash/fp/keyBy.js'; import _keyBy from 'lodash/fp/keyBy.js';
import * as React from 'react'; import * as React from 'react';
// eslint-disable-next-line import/extensions // eslint-disable-next-line import/extensions
import ReactDOMServer from 'react-dom/server'; import ReactDOMServer from 'react-dom/server';
import t from 'tcomb'; import t from 'tcomb';
import { promisify } from 'util'; import { promisify } from 'util';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { baseLegalPolicies } from 'lib/facts/policies.js'; import { baseLegalPolicies } from 'lib/facts/policies.js';
import stores from 'lib/facts/stores.js'; import stores from 'lib/facts/stores.js';
import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js'; import { daysToEntriesFromEntryInfos } from 'lib/reducers/entry-reducer.js';
import { freshMessageStore } from 'lib/reducers/message-reducer.js'; import { freshMessageStore } from 'lib/reducers/message-reducer.js';
import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js'; import { mostRecentlyReadThread } from 'lib/selectors/thread-selectors.js';
import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js'; import { mostRecentMessageTimestamp } from 'lib/shared/message-utils.js';
import { import {
threadHasPermission, threadHasPermission,
▲ Show 20 Lines • Show All 775 Lines • ▼ Show 20 Lines <html lang="en">
</section> </section>
<p> <p>
To join this community, download the Comm app and reopen this invite To join this community, download the Comm app and reopen this invite
link link
</p> </p>
<div class="separator"></div> <div class="separator"></div>
<section class="buttons"> <section class="buttons">
<a class="button" href="${stores.appStoreUrl}">Download Comm</a> <a class="button" href="${stores.appStoreUrl}">Download Comm</a>
<a class="button secondary" href="${inviteLinkUrl(secret)}"> <a class="button secondary" href="${inviteLinkURL(secret)}">
Invite Link Invite Link
</a> </a>
</section> </section>
</section> </section>
<a class="link" href="https://comm.app/"> <a class="link" href="https://comm.app/">
<span class="link-text">Visit Comm’s website</span> <span class="link-text">Visit Comm’s website</span>
<img <img
src="/images/arrow_up_right.svg" src="/images/arrow_up_right.svg"
Show All 10 Lines
View Options

lib/shared/updates/update-spec.js

Loading...
View Options

lib/shared/updates/update-thread-spec.js

Loading...