Page MenuHomePhabricator

[services] Backup - prevent sending logs for non-existing backups
ClosedPublic

Authored by karol on May 19 2022, 3:00 AM.
Tags
None
Referenced Files
F3275470: D4075.diff
Sat, Nov 16, 7:06 AM
Unknown Object (File)
Tue, Nov 5, 3:23 PM
Unknown Object (File)
Oct 13 2024, 5:41 PM
Unknown Object (File)
Oct 13 2024, 5:41 PM
Unknown Object (File)
Oct 13 2024, 5:40 PM
Unknown Object (File)
Oct 13 2024, 5:33 PM
Unknown Object (File)
Sep 4 2024, 6:46 AM
Unknown Object (File)
Sep 3 2024, 5:26 AM

Details

Summary

Depends on D4074

This is a bug fix. If the backup for the given backup id does not exist in the database, we should abort sending log.

Test Plan
  • terminal 1
cd services
yarn run-blob-service-dev-mode
  • terminal 2
cd services
yarn run-backup-service-dev-mode
  • terminal 3
git clone https://github.com/karol-bisztyga/grpc-playground.git
cd grpc-playground
git checkout backup-async

You can hard-code some fake backup-id in the code (Client.h - lastBackupID)

./build.sh
./cmake/build/bin/client

Then in terminal 3 create a new log

l

With an invalid current backup id, the log cannot be sent.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable