Paths

Table of Contentst

[Services] Update generated proto files
ClosedPublic
Actions

Authored by • jon on Jul 29 2022, 9:53 PM.

Details

Reviewers

• karol
• max
atul
• abosh

Commits

rCOMMd839b48b9979: [Services] Update generated proto files

Summary

Needed for blob build to work

just ran cd native && yarn codegen-grpc

Test Plan

Follow test plan for blob diff in stack

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jul 29 2022, 9:53 PM

Herald added subscribers: • adrian, tomek, ashoat. · View Herald TranscriptJul 29 2022, 9:53 PM

• jon added a parent revision: D4630: [Services] Install double and folly in base-image.Jul 29 2022, 9:58 PM

• jon added a child revision: D4671: [Services] Update tunnelbroker Dockerfile & cmake.

• jon added a child revision: D4685: [Services] Make build_service.sh PWD independent.Jul 29 2022, 10:00 PM

• jon removed a child revision: D4671: [Services] Update tunnelbroker Dockerfile & cmake.Jul 29 2022, 10:06 PM

Harbormaster completed remote builds in B10981: Diff 15115.Jul 29 2022, 10:06 PM

• jon requested review of this revision.Jul 29 2022, 10:06 PM

Re-opened https://linear.app/comm/issue/ENG-777 to prevent this in the future

atul added 1 blocking reviewer(s): • karol.Aug 1 2022, 8:20 PM

atul added 1 blocking reviewer(s): • max.

• karol accepted this revision.Aug 2 2022, 9:46 AM

• max accepted this revision.Aug 2 2022, 6:49 PM

This revision is now accepted and ready to land.Aug 2 2022, 6:49 PM

Closed by commit rCOMMd839b48b9979: [Services] Update generated proto files. · Explain WhyAug 4 2022, 4:27 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMMd839b48b9979: [Services] Update generated proto files.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

grpc/

_generated/

backup.pb.h

backup.pb.cc

tunnelbroker.grpc.pb.h

tunnelbroker.grpc.pb.cc

tunnelbroker.pb.h

tunnelbroker.pb.cc

Diff 15287

View Options

native/cpp/CommonCpp/grpc/_generated/backup.pb.h

View Options

native/cpp/CommonCpp/grpc/_generated/backup.pb.cc

View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.h

View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.cc

View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.h

View Options

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.cc

[Services] Update generated proto filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 15287

native/cpp/CommonCpp/grpc/_generated/backup.pb.h

native/cpp/CommonCpp/grpc/_generated/backup.pb.cc

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.h

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.grpc.pb.cc

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.h

native/cpp/CommonCpp/grpc/_generated/tunnelbroker.pb.cc

[Services] Update generated proto files
ClosedPublic
Actions

Revision Contents
Changeset List