Paths

Table of Contentst

Differential D5402

[native] [9/34] ReactNav6: separate StackNavigationProp from StackNavigationHelpers
ClosedPublic
Actions

Authored by ashoat on Oct 20 2022, 6:12 AM.

Tags

None

Referenced Files

	F3249066: D5402.diff
	Fri, Nov 15, 12:16 PM

	Unknown Object (File)
	Mon, Nov 11, 1:51 AM

	Unknown Object (File)
	Mon, Oct 28, 5:08 AM

	Unknown Object (File)
	Mon, Oct 28, 5:07 AM

	Unknown Object (File)
	Mon, Oct 28, 5:05 AM

	Unknown Object (File)
	Wed, Oct 16, 9:35 PM

	Unknown Object (File)
	Oct 9 2024, 10:19 AM

	Unknown Object (File)
	Sep 26 2024, 7:08 PM

Subscribers

Details

Reviewers

atul
tomek
bartek

Commits

rCOMMfdbe8fd2d6dd: [native] [9/34] ReactNav6: separate StackNavigationProp from…

Summary

We want to type setParams correctly for both the specific-screen and any-screen-on-a-navigator case. As a result, the type of setParams is incompatible between the two.

Note that I have left off setParams from NavigationHelpers in this diff. That's because I need to make some changes to our codebase before I can do that without leading to Flow errors... otherwise the two setParams will collide. I will reintroduce setParams to NavigationHelpers in a later diff in the stack.

Depends on D5401

Test Plan

Flow + ran the app on my phone and played around with it

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 20 2022, 6:12 AM

Herald added a subscriber: • abosh. · View Herald TranscriptOct 20 2022, 6:12 AM

ashoat added a child revision: D5403: [native] [10/34] ReactNav6: separate TabNavigationProp from TabNavigationHelpers.Oct 20 2022, 6:13 AM

ashoat mentioned this in D5406: [native] [13/34] ReactNav6: add setParams to NavigationHelpers.

Harbormaster completed remote builds in B12889: Diff 17680.Oct 20 2022, 6:34 AM

ashoat requested review of this revision.Oct 20 2022, 6:34 AM

atul accepted this revision.Oct 20 2022, 9:53 AM

This revision is now accepted and ready to land.Oct 20 2022, 9:53 AM

Closed by commit rCOMMfdbe8fd2d6dd: [native] [9/34] ReactNav6: separate StackNavigationProp from… (authored by ashoat). · Explain WhyOct 20 2022, 1:47 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfdbe8fd2d6dd: [native] [9/34] ReactNav6: separate StackNavigationProp from….

ashoat mentioned this in rCOMMb1015ced52d0: [native] [13/34] ReactNav6: add setParams to NavigationHelpers.

Revision Contents
Changeset List

Path

Size

native/

chat/

8 lines

21 lines

flow-typed/

npm/

@react-navigation/

bottom-tabs_v5.x.x.js

63 lines

devtools_v5.x.x.js

63 lines

material-top-tabs_v5.x.x.js

63 lines

native_v5.x.x.js

63 lines

stack_v5.x.x.js

65 lines

navigation/

app-navigator.react.js

9 lines

overlay-navigator.react.js

25 lines

overlay-router.js

8 lines

root-navigator.react.js

32 lines

8 lines

profile/

profile.react.js

3 lines

Diff 17765

native/chat/chat-router.js

Loading...

native/chat/chat.react.js

Loading...

native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js

Loading...

native/flow-typed/npm/@react-navigation/devtools_v5.x.x.js

Loading...

native/flow-typed/npm/@react-navigation/material-top-tabs_v5.x.x.js

Loading...

native/flow-typed/npm/@react-navigation/native_v5.x.x.js

Loading...

native/flow-typed/npm/@react-navigation/stack_v5.x.x.js

Loading...

native/navigation/app-navigator.react.js

Loading...

native/navigation/overlay-navigator.react.js

Loading...

native/navigation/overlay-router.js

Loading...

native/navigation/root-navigator.react.js

Loading...

native/navigation/root-router.js

Loading...

native/profile/profile.react.js

Loading...