Page MenuHomePhabricator

[services][backup] PullBackup 4/5 - blob stored item
ClosedPublic

Authored by bartek on Jan 11 2023, 3:30 PM.
Tags
None
Referenced Files
F3502585: D6243.id21113.diff
Fri, Dec 20, 4:25 AM
F3502584: D6243.id20827.diff
Fri, Dec 20, 4:25 AM
F3502583: D6243.id21097.diff
Fri, Dec 20, 4:25 AM
F3502582: D6243.id20925.diff
Fri, Dec 20, 4:25 AM
F3502522: D6243.id.diff
Fri, Dec 20, 4:24 AM
F3502472: D6243.diff
Fri, Dec 20, 4:16 AM
Unknown Object (File)
Thu, Nov 28, 4:29 AM
Unknown Object (File)
Thu, Nov 28, 4:29 AM
Subscribers

Details

Summary

Second part of transport-business logic separation (see parent diff description). This diff abstracts both BackupItem and LogItem as some objects stored in blob service that can be sent to the client as PullBackupResponse.
Each stored object must have holder. Also, such object knows how to construct a response, what metadata to include in it and what size it is.

This trait will be used in the next diff to create a generic blob-service-download stream and avoid lots of code duplication.

Depends on D6242

Test Plan

This trait is tested altogether with other diffs for this endpoint

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Jan 11 2023, 3:56 PM
This revision is now accepted and ready to land.Jan 12 2023, 8:58 AM

Renamed fields_extra_size to metadata_size - this name is more accurate