Page MenuHomePhabricator
Differential D6156

[native, lib] Move community drawer related code that can be reused on web from native to lib
ClosedPublic
Actions

Authored by inka on Jan 4 2023, 3:12 AM.
Tags
None
Referenced Files
F3379603: D6156.diff
Wed, Nov 27, 5:30 PM
Unknown Object (File)
Mon, Nov 25, 9:07 AM
Unknown Object (File)
Sun, Nov 24, 2:42 PM
Unknown Object (File)
Sun, Nov 24, 7:35 AM
Unknown Object (File)
Fri, Nov 22, 3:44 AM
Unknown Object (File)
Tue, Nov 19, 11:35 AM
Unknown Object (File)
Sat, Nov 16, 7:29 PM
Unknown Object (File)
Fri, Nov 15, 6:01 PM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ginsu
• przemek
michal
tomek
Commits
rCOMM324ae1cda82b: [native, lib] Move community drawer related code that can be reused on web from…
Summary

Some code used for community drawer on native can be reused for community drawer on web, so I moved it to lib.

Test Plan

run iOS simulator, checked that communinty drawer works as expected.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Jan 4 2023, 3:12 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptJan 4 2023, 3:12 AM
Harbormaster completed remote builds in B15071: Diff 20562.Jan 4 2023, 3:26 AM
inka requested review of this revision.Jan 4 2023, 3:26 AM
inka added a child revision: D6160: [web] Add drawer item implementations.Jan 4 2023, 5:56 AM
michal added inline comments.Jan 5 2023, 2:36 AM
native/navigation/community-drawer-content.react.js
45–56 ↗(On Diff #20562)

This now can be simplified.

• przemek accepted this revision.Jan 5 2023, 4:07 AM

Looks good besides nit from @michal

This revision is now accepted and ready to land.Jan 5 2023, 4:07 AM
inka updated this revision to Diff 20672.Jan 9 2023, 4:19 AM

Simplify

Harbormaster completed remote builds in B15161: Diff 20672.Jan 9 2023, 4:31 AM
inka added a reviewer: tomek.Jan 10 2023, 2:40 AM
This revision now requires review to proceed.Jan 10 2023, 2:40 AM
tomek accepted this revision.Jan 10 2023, 9:09 AM
tomek added inline comments.
lib/utils/drawer-utils.react.js
7 ↗(On Diff #20672)

We usually prefer more descriptive type parameters. Maybe LabelStyleType?

This revision is now accepted and ready to land.Jan 10 2023, 9:09 AM
inka updated this revision to Diff 20790.Jan 11 2023, 5:42 AM

Make type parameter more descriptive

Harbormaster completed remote builds in B15250: Diff 20790.Jan 11 2023, 5:55 AM
inka updated this revision to Diff 21311.Jan 25 2023, 3:50 AM

Rebase

Harbormaster completed remote builds in B15630: Diff 21311.Jan 25 2023, 4:04 AM
inka updated this revision to Diff 22112.Feb 6 2023, 2:11 AM

Rebase

Harbormaster failed remote builds in B16162: Diff 22112!Feb 6 2023, 8:12 AM
Harbormaster completed remote builds in B16162: Diff 22112.Feb 8 2023, 3:41 AM
inka updated this revision to Diff 22433.Feb 13 2023, 7:09 AM

Rebase

Harbormaster completed remote builds in B16396: Diff 22433.Feb 13 2023, 7:37 AM
inka updated this revision to Diff 22521.Feb 14 2023, 2:24 AM

Rebase

Harbormaster completed remote builds in B16474: Diff 22521.Feb 14 2023, 2:39 AM
Closed by commit rCOMM324ae1cda82b: [native, lib] Move community drawer related code that can be reused on web from… (authored by • InkaSokolowska). · Explain WhyFeb 14 2023, 5:01 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMM324ae1cda82b: [native, lib] Move community drawer related code that can be reused on web from….

Revision Contents
Changeset List

PathSize
lib/
utils/
79 lines
native/
navigation/
98 lines
13 lines

Diff 21311

View Options

lib/utils/drawer-utils.react.js

Loading...
View Options

native/navigation/community-drawer-content.react.js

Loading...
View Options

native/navigation/community-drawer-item.react.js

Loading...