Page MenuHomePhabricator
Differential D6856

[services][feature-flags] Parse feature flags response from DynamoDB
ClosedPublic
Actions

Authored by tomek on Feb 23 2023, 8:14 AM.
Tags
None
Referenced Files
F3381374: D6856.id23140.diff
Thu, Nov 28, 4:43 AM
F3380754: D6856.diff
Thu, Nov 28, 1:55 AM
Unknown Object (File)
Sat, Nov 23, 5:05 AM
Unknown Object (File)
Oct 26 2024, 10:18 PM
Unknown Object (File)
Oct 26 2024, 10:18 PM
Unknown Object (File)
Oct 26 2024, 10:18 PM
Unknown Object (File)
Oct 26 2024, 10:18 PM
Unknown Object (File)
Oct 26 2024, 10:17 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
michal
bartek
• jon
varun
Commits
rCOMM3684fe489698: [services][feature-flags] Parse feature flags response from DynamoDB
Summary

Parse the response into struct.

Depends on D6855

Test Plan

Tested with the next diffs.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Feb 23 2023, 8:14 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 23 2023, 8:14 AM
tomek edited the summary of this revision. (Show Details)Feb 23 2023, 8:14 AM
tomek added a parent revision: D6855: [services][feature-flags] Introduce map and i32 parsing.
tomek added a child revision: D6857: [services][feature-flags] Query the db.Feb 23 2023, 8:18 AM
Harbormaster completed remote builds in B16831: Diff 23009.Feb 23 2023, 8:30 AM
tomek requested review of this revision.Feb 23 2023, 8:30 AM
bartek added inline comments.Feb 24 2023, 1:48 AM
services/feature-flags/src/database.rs
140

IMO the underscore renames for _parse_xxx_attribute should be done in this diff because they're no longer unused. My motivation is to keep the number of underscores as minimal as possible for each diff.

Anyway I see they're renamed in the following diff and I'm OK with that too

bartek accepted this revision.Feb 24 2023, 2:00 AM
This revision is now accepted and ready to land.Feb 24 2023, 2:00 AM
bartek added inline comments.Feb 24 2023, 2:03 AM
services/feature-flags/src/database.rs
140

Never mind, I forgot that Rust displays warnings recursively for unused functions

tomek added inline comments.Feb 27 2023, 3:52 AM
services/feature-flags/src/database.rs
140

That's correct - all the underscores were necessary. After introducing the shared lib, number of underscores was decreased, though.

tomek updated this revision to Diff 23140.Feb 27 2023, 3:54 AM

Rebase

Harbormaster failed remote builds in B16930: Diff 23140!Feb 27 2023, 3:59 AM
tomek updated this revision to Diff 23167.Feb 27 2023, 8:20 AM

Rebase

Harbormaster completed remote builds in B16946: Diff 23167.Feb 27 2023, 8:35 AM
Closed by commit rCOMM3684fe489698: [services][feature-flags] Parse feature flags response from DynamoDB (authored by tomek). · Explain WhyFeb 28 2023, 6:26 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM3684fe489698: [services][feature-flags] Parse feature flags response from DynamoDB.

Revision Contents
Changeset List

PathSize
services/
feature-flags/
src/
57 lines

Diff 23009

View Options

services/feature-flags/src/database.rs

Loading...