Page MenuHomePhabricator
Differential D7620

[lib][keyserver] Expose upload_media_metadata endpoint
ClosedPublic
Actions

Authored by bartek on Apr 25 2023, 11:28 AM.
Tags
None
Referenced Files
F6311752: D7620.id26194.diff
Sat, Apr 26, 12:21 PM
Unknown Object (File)
Thu, Apr 17, 3:08 PM
Unknown Object (File)
Thu, Apr 17, 4:35 AM
Unknown Object (File)
Thu, Apr 17, 4:16 AM
Unknown Object (File)
Thu, Apr 17, 4:14 AM
Unknown Object (File)
Wed, Apr 16, 11:04 PM
Unknown Object (File)
Wed, Apr 16, 3:26 PM
Unknown Object (File)
Wed, Apr 9, 12:13 AM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
atul
marcin
inka
Commits
rCOMMfc743d8532ea: [lib][keyserver] Expose upload_media_metadata endpoint
Summary

This diff exposes the upload_media_metadata endpoint.

Depends on D7619

Test Plan

Created useServerCall hook and called this endpoint. Verified that a new record is added to the uploads table.
The endpoint response format is the same as the upload_multimedia endpoint.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Apr 25 2023, 11:28 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptApr 25 2023, 11:28 AM
bartek published this revision for review.Apr 25 2023, 11:46 AM
Harbormaster completed remote builds in B18754: Diff 25694.Apr 25 2023, 11:48 AM
ashoat accepted this revision.Apr 25 2023, 12:48 PM
ashoat added inline comments.
lib/actions/upload-actions.js
28 ↗(On Diff #25694)

Since we directly return the result from the server here, it would be good to make sure that the code that consumes this will not break if the server starts including some new additional key

This revision is now accepted and ready to land.Apr 25 2023, 12:48 PM
bartek updated this revision to Diff 25809.Apr 27 2023, 3:47 AM

Rebase. Opted out of direct return, for similiar reasons as discussed in D7522

Harbormaster completed remote builds in B18840: Diff 25809.Apr 27 2023, 4:07 AM
bartek added a child revision: D7649: [native] Add function to upload media to blob service.Apr 27 2023, 4:31 AM
bartek added a child revision: D7689: [web] Add function to upload media to Blob service.Apr 29 2023, 9:20 AM
bartek updated this revision to Diff 26191.May 8 2023, 4:54 AM

Rebase before landing

Harbormaster completed remote builds in B19131: Diff 26191.May 8 2023, 5:12 AM
Closed by commit rCOMMfc743d8532ea: [lib][keyserver] Expose upload_media_metadata endpoint (authored by bartek). · Explain WhyMay 8 2023, 5:19 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMfc743d8532ea: [lib][keyserver] Expose upload_media_metadata endpoint.

Revision Contents
Changeset List

PathSize
keyserver/
src/
9 lines
lib/
actions/
19 lines
types/
1 line

Diff 25809

View Options

keyserver/src/endpoints.js

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Linesimport {
logInResponder, logInResponder,
siweAuthResponder, siweAuthResponder,
oldPasswordUpdateResponder, oldPasswordUpdateResponder,
updateUserSettingsResponder, updateUserSettingsResponder,
policyAcknowledgmentResponder, policyAcknowledgmentResponder,
updateUserAvatarResponder, updateUserAvatarResponder,
} from './responders/user-responders.js'; } from './responders/user-responders.js';
import { codeVerificationResponder } from './responders/verification-responders.js'; import { codeVerificationResponder } from './responders/verification-responders.js';
import { uploadDeletionResponder } from './uploads/uploads.js'; import {
uploadMediaMetadataResponder,
uploadDeletionResponder,
} from './uploads/uploads.js';
const jsonEndpoints: { [id: Endpoint]: JSONResponder } = { const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
create_account: { create_account: {
responder: accountCreationResponder, responder: accountCreationResponder,
requiredPolicies: [], requiredPolicies: [],
}, },
create_entry: { create_entry: {
responder: entryCreationResponder, responder: entryCreationResponder,
▲ Show 20 Lines • Show All 182 Lines • ▼ Show 20 Linesconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {
siwe_auth: { siwe_auth: {
responder: siweAuthResponder, responder: siweAuthResponder,
requiredPolicies: [], requiredPolicies: [],
}, },
update_user_avatar: { update_user_avatar: {
responder: updateUserAvatarResponder, responder: updateUserAvatarResponder,
requiredPolicies: baseLegalPolicies, requiredPolicies: baseLegalPolicies,
}, },
upload_media_metadata: {
responder: uploadMediaMetadataResponder,
requiredPolicies: baseLegalPolicies,
},
}; };
export { jsonEndpoints }; export { jsonEndpoints };
View Options

lib/actions/upload-actions.js

// @flow // @flow
import type { Shape } from '../types/core.js'; import type { Shape } from '../types/core.js';
import type { import type {
UploadMediaMetadataRequest,
UploadMultimediaResult, UploadMultimediaResult,
Dimensions, Dimensions,
} from '../types/media-types.js'; } from '../types/media-types';
import type { CallServerEndpoint } from '../utils/call-server-endpoint.js'; import type { CallServerEndpoint } from '../utils/call-server-endpoint.js';
import type { UploadBlob } from '../utils/upload-blob.js'; import type { UploadBlob } from '../utils/upload-blob.js';
export type MultimediaUploadCallbacks = Shape<{ export type MultimediaUploadCallbacks = Shape<{
onProgress: (percent: number) => void, onProgress: (percent: number) => void,
abortHandler: (abort: () => void) => void, abortHandler: (abort: () => void) => void,
uploadBlob: UploadBlob, uploadBlob: UploadBlob,
}>; }>;
export type MultimediaUploadExtras = Shape<{ export type MultimediaUploadExtras = Shape<{
...Dimensions, ...Dimensions,
loop: boolean, loop: boolean,
encryptionKey?: string, encryptionKey?: string,
}>; }>;
const uploadMediaMetadata =
(
callServerEndpoint: CallServerEndpoint,
): ((input: UploadMediaMetadataRequest) => Promise<UploadMultimediaResult>) =>
async input => {
const response = await callServerEndpoint('upload_media_metadata', input);
return {
id: response.id,
uri: response.uri,
mediaType: response.mediaType,
dimensions: response.dimensions,
loop: response.loop,
};
};
const uploadMultimedia = const uploadMultimedia =
( (
callServerEndpoint: CallServerEndpoint, callServerEndpoint: CallServerEndpoint,
): (( ): ((
multimedia: Object, multimedia: Object,
extras: MultimediaUploadExtras, extras: MultimediaUploadExtras,
callbacks?: MultimediaUploadCallbacks, callbacks?: MultimediaUploadCallbacks,
) => Promise<UploadMultimediaResult>) => ) => Promise<UploadMultimediaResult>) =>
▲ Show 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
const deleteUpload = const deleteUpload =
(callServerEndpoint: CallServerEndpoint): ((id: string) => Promise<void>) => (callServerEndpoint: CallServerEndpoint): ((id: string) => Promise<void>) =>
async id => { async id => {
await callServerEndpoint('delete_upload', { id }); await callServerEndpoint('delete_upload', { id });
}; };
export { export {
uploadMultimedia, uploadMultimedia,
uploadMediaMetadata,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
deleteUpload, deleteUpload,
}; };
View Options

lib/types/endpoints.js

Show First 20 Lines • Show All 81 Lines • ▼ Show 20 Linesconst socketPreferredEndpoints = Object.freeze({
UPDATE_RELATIONSHIPS: 'update_relationships', UPDATE_RELATIONSHIPS: 'update_relationships',
UPDATE_ROLE: 'update_role', UPDATE_ROLE: 'update_role',
UPDATE_THREAD: 'update_thread', UPDATE_THREAD: 'update_thread',
UPDATE_USER_SUBSCRIPTION: 'update_user_subscription', UPDATE_USER_SUBSCRIPTION: 'update_user_subscription',
VERIFY_CODE: 'verify_code', VERIFY_CODE: 'verify_code',
SIWE_NONCE: 'siwe_nonce', SIWE_NONCE: 'siwe_nonce',
SIWE_AUTH: 'siwe_auth', SIWE_AUTH: 'siwe_auth',
UPDATE_USER_AVATAR: 'update_user_avatar', UPDATE_USER_AVATAR: 'update_user_avatar',
UPLOAD_MEDIA_METADATA: 'upload_media_metadata',
}); });
type SocketPreferredEndpoint = $Values<typeof socketPreferredEndpoints>; type SocketPreferredEndpoint = $Values<typeof socketPreferredEndpoints>;
const httpPreferredEndpoints = Object.freeze({ const httpPreferredEndpoints = Object.freeze({
CREATE_REPORT: 'create_report', CREATE_REPORT: 'create_report',
CREATE_REPORTS: 'create_reports', CREATE_REPORTS: 'create_reports',
}); });
type HTTPPreferredEndpoint = $Values<typeof httpPreferredEndpoints>; type HTTPPreferredEndpoint = $Values<typeof httpPreferredEndpoints>;
Show All 22 Lines