[native] replace `uint` with `unsigned int`
ClosedPublic
Actions

Authored by kamil on Jul 12 2023, 6:21 AM.

Details

Reviewers

michal
tomek
• jon
atul

Commits

rCOMM6c0a01336cc0: [native] replace `uint` with `unsigned int`

Summary

Emscripten compiler (for some reason) does not recognize uint, and cause: error: use of undeclared identifier 'uint'; did you mean 'int'?

Depends on D8488

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Branch

wasm-native

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 12 2023, 6:21 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 12 2023, 6:21 AM

Harbormaster completed remote builds in B20904: Diff 28635.Jul 12 2023, 6:39 AM

kamil published this revision for review.Jul 12 2023, 7:37 AM

Seems like unsigned int is the official type, and uint is typedefs by some compilers automatically

This revision is now accepted and ready to land.Jul 14 2023, 2:27 AM

kamil added a child revision: D8553: [web] add SQLiteQueryExecutor bindings and type.Jul 19 2023, 6:49 AM

Closed by commit rCOMM6c0a01336cc0: [native] replace `uint` with `unsigned int` (authored by kamil). · Explain WhyJul 20 2023, 6:56 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM6c0a01336cc0: [native] replace `uint` with `unsigned int`.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

2 lines

Diff 28635

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

[native] replace `uint` with `unsigned int`ClosedPublicActions