Details

native/roles/role-utils.react.js
40–52 ↗	(On Diff #29062)	Given we also have something like this for `web` (D8625), it makes sense to move the construction of this `message` to `lib` so it can be kept in sync across platforms.

This revision now requires changes to proceed.Jul 26 2023, 3:40 PM

Extract message extraction to lib

Harbormaster completed remote builds in B21240: Diff 29084.Jul 27 2023, 12:52 AM

Rebase

Harbormaster completed remote builds in B21252: Diff 29096.Jul 27 2023, 2:35 AM

Looks good, thanks for addressing feedback!

lib/utils/role-utils.js

38–56

Now that we have this pulled out into utils function, we could add some quick unit tests?

I think we can just cut/paste these:

const { constructRoleDeletionMessagePrompt } = require('./path_to_your_function');

describe('constructRoleDeletionMessagePrompt', () => {
  it('should return generic deletion message if no members have this role', () => {
    const result = constructRoleDeletionMessagePrompt('defaultRole', 0);
    expect(result).toBe('Are you sure you want to delete this role?');
  });

  it('should correctly format message for single member', () => {
    const result = constructRoleDeletionMessagePrompt('defaultRole', 1);
    expect(result).toBe('There is currently 1 member with this role. Deleting the role will automatically assign the member affected to the defaultRole role.');
  });

  it('should correctly format message for multiple members', () => {
    const result = constructRoleDeletionMessagePrompt('defaultRole', 5);
    expect(result).toBe('There are currently 5 members with this role. Deleting the role will automatically assign the members affected to the defaultRole role.');
  });

  it('should correctly incorporate the name of the default role', () => {
    const result = constructRoleDeletionMessagePrompt('testRole', 5);
    expect(result).toBe('There are currently 5 members with this role. Deleting the role will automatically assign the members affected to the testRole role.');
  });
});