Differential D8523
[native] Display an action sheet with the 'edit role' option Authored by rohan on Jul 17 2023, 10:44 AM. Tags None Referenced Files
Details The first option we display to the user is an "Edit role" item, where clicking it will take them to the role name / permissions screen. This diff just handles the action sheet, but the next one will Depends on D8522 Verified that on iOS and Android, the action sheet looks as expected. 
Diff Detail
Event TimelineComment Actions accepting so I don't block this diff and also my concerns are outside the scope of this diff; however, it is becoming very obvious that we need our own shared action sheet component that abstracts a lot of the similar patterns surrounding the actions sheet (only showing cancel for iOS in options, the cancelButtonIndex, the userInterfaceStyle, etc). This task should help with addressing this concern too since we should be able to deprecate most of this logic in favor for our own custom bottomsheet. Comment Actions Yeah I completely agree with this, I think converting to a custom bottomsheet (or at the very least in the short term having a shared action sheet component if the bottomsheet won't be prioritized) is going to help keep things consistent, and also make the conversion from actionsheet --> bottomsheet a lot easier |