[native] update dummyNodeForTextMessageHeightMeasurement to use dummy inline engagement component
ClosedPublic
Actions

Authored by ginsu on Jul 25 2023, 1:34 PM.

Details

Reviewers

kamil
ashoat
tomek
atul

Commits

rCOMM956243bbe4ae: [native] update dummyNodeForTextMessageHeightMeasurement to use dummy inline…

Summary

This diff adds the dummy inline engagement component to the text message dummy node, so that we can correctly measure text messages with an inline engagement. A subsequent diff will handle updating the heightMeasurerKey for text messages

Depends on D8629

Test Plan

Confirmed that the incorrect height measurement log was no longer in the console. Also double checked in the inspector that I was getting the correct height measurements for both dummy nodes

Before:

Screenshot 2023-07-25 at 3.53.31 PM.png (1×3 px, 1 MB)

After:

Screenshot 2023-07-25 at 4.30.32 PM.png (1×3 px, 1 MB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 25 2023, 1:34 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 25 2023, 1:34 PM

ginsu edited the summary of this revision. (Show Details)Jul 25 2023, 1:35 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil, ashoat, tomek.

ginsu added a parent revision: D8629: [lib/native/web] update getMessageLabel parameters.

ginsu attached a referenced file: F653907: Screenshot 2023-07-25 at 4.30.32 PM.png. (Show Details)

ginsu attached a referenced file: F653906: Screenshot 2023-07-25 at 3.53.31 PM.png. (Show Details)

Harbormaster completed remote builds in B21198: Diff 29034.Jul 25 2023, 1:56 PM

ginsu requested review of this revision.Jul 25 2023, 1:56 PM

ginsu added a child revision: D8632: [native] update heightMeasurerKey function to consider inline engagement for text messages.Jul 25 2023, 2:28 PM

atul resigned from this revision.Jul 25 2023, 11:32 PM

tomek accepted this revision.Jul 26 2023, 3:21 AM

tomek added inline comments.

native/chat/inner-text-message.react.js
40 ↗	(On Diff #29034)	Should we apply some styles to this View?
native/chat/utils.js
81–88 ↗	(On Diff #29034)	Do we still need these constants?

This revision is now accepted and ready to land.Jul 26 2023, 3:21 AM

ginsu added inline comments.Jul 26 2023, 3:35 PM

native/chat/inner-text-message.react.js
40 ↗	(On Diff #29034)	Here is an explanation for why I added the View here: https://phab.comm.dev/D8610#inline-55215
native/chat/utils.js
81–88 ↗	(On Diff #29034)	These constants are still used, but in D8634 we do remove the unused constants here