Page MenuHomePhabricator
Differential D9074

[client-backup] extract logic for getting primary identity public key
ClosedPublic
Actions

Authored by kamil on Sep 4 2023, 1:53 AM.
Tags
None
Referenced Files
F3369165: D9074.diff
Mon, Nov 25, 10:07 PM
Unknown Object (File)
Fri, Nov 22, 4:12 PM
Unknown Object (File)
Tue, Oct 29, 10:37 AM
Unknown Object (File)
Sun, Oct 27, 4:09 PM
Unknown Object (File)
Oct 23 2024, 6:38 PM
Unknown Object (File)
Oct 22 2024, 12:16 AM
Unknown Object (File)
Oct 2 2024, 11:44 PM
Unknown Object (File)
Sep 27 2024, 11:27 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
marcin
bartek
Commits
rCOMM567c03b1e045: [client-backup] extract logic for getting primary identity public key
Summary

This code is duplicated and will be duplicated, so wrapping this in one function.

Depends on D9001

Test Plan

Verify function result is correct (SIWE login)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Sep 4 2023, 1:53 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 4 2023, 1:53 AM
kamil updated this revision to Diff 30730.Sep 4 2023, 1:54 AM

remove await

kamil updated this revision to Diff 30731.Sep 4 2023, 1:55 AM

fix typo

Harbormaster failed remote builds in B22362: Diff 30729!Sep 4 2023, 2:04 AM
Harbormaster failed remote builds in B22363: Diff 30730!
Harbormaster completed remote builds in B22364: Diff 30731.Sep 4 2023, 2:12 AM
kamil added a child revision: D9002: [client-backup] implement initial restore backup protocol.Sep 4 2023, 3:00 AM
kamil published this revision for review.Sep 4 2023, 3:02 AM
kamil mentioned this in D9001: [client-backup] implement initial backup protocol.
marcin requested changes to this revision.Sep 5 2023, 1:48 AM
  1. Primary keyword is not valid when talking about the "main" olm account - the convention is to use Content keyword.
  2. Identity keyword refers to curve25519. ed25519 is signing key.

That said the correct name for this function is getContentSigningKey. This is not a nit - this is important to stick to this naming convention as those keys are used across different programming languages.

This revision now requires changes to proceed.Sep 5 2023, 1:48 AM
kamil updated this revision to Diff 30742.Sep 5 2023, 2:09 AM

rename to getContentSigningKey

marcin accepted this revision.Sep 5 2023, 2:22 AM
marcin added inline comments.
native/account/siwe-panel.react.js
83

If it doesn't takie to much effort it would be nice to rename this function as well as it looks like naming discrepancy from the first sight.

This revision is now accepted and ready to land.Sep 5 2023, 2:22 AM
Harbormaster completed remote builds in B22375: Diff 30742.Sep 5 2023, 2:27 AM
Closed by commit rCOMM567c03b1e045: [client-backup] extract logic for getting primary identity public key (authored by kamil). · Explain WhySep 5 2023, 5:13 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM567c03b1e045: [client-backup] extract logic for getting primary identity public key.

Revision Contents
Changeset List

PathSize
native/
account/
7 lines
backup/
15 lines
utils/
10 lines

Diff 30742

View Options

native/account/siwe-panel.react.js

Loading...
View Options

native/backup/use-client-backup.js

Loading...
View Options

native/utils/crypto-utils.js

Loading...