Page MenuHomePhabricator

[native] introduce user profile bottomsheet component
ClosedPublic

Authored by ginsu on Sep 7 2023, 10:05 AM.
Tags
None
Referenced Files
F3140806: D9101.id30850.diff
Sun, Nov 3, 5:26 AM
F3140780: D9101.id31002.diff
Sun, Nov 3, 5:21 AM
Unknown Object (File)
Sat, Oct 26, 1:12 AM
Unknown Object (File)
Tue, Oct 22, 4:36 PM
Unknown Object (File)
Tue, Oct 22, 3:50 PM
Unknown Object (File)
Sun, Oct 20, 9:30 AM
Unknown Object (File)
Sun, Oct 20, 9:30 AM
Unknown Object (File)
Sun, Oct 20, 9:30 AM
Subscribers

Details

Summary

This diff introduces the ProfileBottomSheet component. When designing this component/how bottomsheets should work in our app, I wanted to take a similar approach to how we currently handle popups/modals in the app today so I created a new screen in root navigator which we will navigate to when the user profile bottomsheet should appear. The "screen" we will navigate to is this ProfileBottomSheet component

Depends on D9098

Test Plan

Confirmed that I am able to navigate to and back from this new "screen".

I created this test function in RelationshipListItem:

onPressTestNav = userInfo => {
  this.props.navigate<'UserProfileBottomSheet'>({
    name: UserProfileBottomSheetRouteName,
    params: {
      userID: userInfo.id,
    },
  });
};

and got the following:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu edited the test plan for this revision. (Show Details)
ginsu edited the summary of this revision. (Show Details)

improve onClosed dep list

native/bottom-sheets/user-profile-bottom-sheet.react.js
13 ↗(On Diff #30850)

This parameter/type is a bit of a naive and will be updated in a subsequent diff.

38 ↗(On Diff #30850)
ginsu published this revision for review.Sep 7 2023, 10:28 AM
This revision is now accepted and ready to land.Sep 12 2023, 5:36 AM
This revision was landed with ongoing or failed builds.Sep 12 2023, 2:31 PM
This revision was automatically updated to reflect the committed changes.