Page MenuHomePhabricator
Differential D9369

[lib][web][native] Refactor actions in message-report-actions.js
ClosedPublic
Actions

Authored by inka on Oct 5 2023, 5:54 AM.
Tags
None
Referenced Files
F3393094: D9369.id31683.diff
Sat, Nov 30, 11:30 AM
F3393088: D9369.id32631.diff
Sat, Nov 30, 11:27 AM
Unknown Object (File)
Thu, Nov 28, 12:42 AM
Unknown Object (File)
Wed, Nov 27, 4:51 PM
Unknown Object (File)
Wed, Nov 27, 2:46 PM
Unknown Object (File)
Wed, Nov 27, 12:52 PM
Unknown Object (File)
Tue, Nov 26, 9:32 PM
Unknown Object (File)
Mon, Nov 25, 6:11 PM
View All Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMMcf28f6074871: [lib][web][native] Refactor actions in message-report-actions.js
Summary

issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions

Test Plan

Tested that the actions work as expected

Diff Detail

Repository
rCOMM Comm
Branch
inka/actions_new_branch
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Oct 5 2023, 5:54 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 5 2023, 5:54 AM
Harbormaster completed remote builds in B23002: Diff 31682.Oct 5 2023, 6:12 AM
inka requested review of this revision.Oct 5 2023, 6:12 AM
inka added a parent revision: D9368: [lib][web][native] Refactor actions in link-actions.js.Oct 5 2023, 6:19 AM
inka updated this revision to Diff 31683.Oct 5 2023, 6:28 AM

Retry

Harbormaster completed remote builds in B23003: Diff 31683.Oct 5 2023, 6:46 AM
inka added a child revision: D9370: [lib][web][native] Refactor actions in thread-actions.js pt.1.Oct 5 2023, 9:02 AM
michal accepted this revision.Oct 11 2023, 1:21 AM
michal added inline comments.
lib/actions/message-report-actions.js
27 ↗(On Diff #31683)

We shouldn't hide await inside of an another expression

This revision is now accepted and ready to land.Oct 11 2023, 1:21 AM
inka updated this revision to Diff 32631.Nov 2 2023, 9:51 AM

Address review

Harbormaster completed remote builds in B23677: Diff 32631.Nov 2 2023, 10:45 AM
Closed by commit rCOMMcf28f6074871: [lib][web][native] Refactor actions in message-report-actions.js (authored by inka). · Explain WhyNov 6 2023, 5:45 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMcf28f6074871: [lib][web][native] Refactor actions in message-report-actions.js.

Revision Contents
Changeset List

PathSize
lib/
actions/
27 lines
native/
chat/
9 lines

Diff 31682

View Options

lib/actions/message-report-actions.js

Loading...
View Options

native/chat/message-report-utils.js

Loading...