Move the logic into specs.
https://linear.app/comm/issue/ENG-4238/use-specs-in-update-fetchers
Paths
| Differential D9442 Authored by tomek on Oct 10 2023, 5:34 AM.
Tags None Referenced Files
Details Summary Move the logic into specs. https://linear.app/comm/issue/ENG-4238/use-specs-in-update-fetchers Test Plan Generate some updates and check if they are fetched from the db.
Diff Detail
Event TimelineHerald added subscribers: will, ashoat. · View Herald TranscriptOct 10 2023, 5:34 AM2023-10-10 05:34:54 (UTC-7) Harbormaster completed remote builds in B23139: Diff 31858.Oct 10 2023, 5:54 AM2023-10-10 05:54:12 (UTC-7) Harbormaster completed remote builds in B23140: Diff 31859.Oct 10 2023, 6:05 AM2023-10-10 06:05:52 (UTC-7) This revision is now accepted and ready to land.Oct 11 2023, 11:20 PM2023-10-11 23:20:38 (UTC-7) Closed by commit rCOMM38b0a18c117f: [lib] Move transforming rows into updates to specs (authored by tomek). · Explain WhyNov 6 2023, 6:58 AM2023-11-06 06:58:50 (UTC-8) This revision was automatically updated to reflect the committed changes. tomek added a parent revision: D9354: [lib] Move inconsistencies finding into specs.Apr 10 2024, 5:15 AM2024-04-10 05:15:33 (UTC-7)
Revision Contents
Diff 31859 keyserver/src/fetchers/update-fetchers.js
lib/shared/updates/bad-device-token-spec.js
lib/shared/updates/delete-account-spec.js
lib/shared/updates/delete-thread-spec.js
|
At this point, nearly every workflow requires additional steps. Maybe we can think about a way to make this seem better in the future -- users should know before reading the footnote that Nix isn't going to do everything for them. But, it will do most of the work for them, and anything else will be smaller.
While the user might still know this, the footnote isn't really helping right now. It makes it seem like we told them Nix will do a lot of things, and then later slid in that they will have to do more things.
Currently, the footnote for these sections has a lot of examples for "additional steps." Plus, "additional steps" is broad and could mean any amount of steps, especially to a user who has no familiarity with the dev environment.
So we should think about that, since most of the time footnotes should be used sparingly. If they end up affecting a large portion of a section, we should just make it information the user knows outside of just the footnote. But this can be a separate issue.