Page MenuHomePhabricator
Differential D9484

[web] make user profile accessible from user entity robotext
ClosedPublic
Actions

Authored by ginsu on Oct 12 2023, 11:12 PM.
Tags
None
Referenced Files
F3753712: D9484.diff
Fri, Jan 10, 2:22 AM
F3735160: D9484.id31990.diff
Thu, Jan 9, 4:12 AM
F3734408: D9484.id32098.diff
Thu, Jan 9, 3:38 AM
Unknown Object (File)
Sun, Dec 22, 3:16 PM
Unknown Object (File)
Sun, Dec 22, 3:08 PM
Unknown Object (File)
Sat, Dec 14, 10:59 PM
Unknown Object (File)
Sat, Dec 14, 5:55 PM
Unknown Object (File)
Sat, Dec 14, 5:55 PM
View All 81 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMMfecb5bd5183f: [web] make user profile accessible from user entity robotext
Summary

This diff makes the user entity in the robotext interactive. When a user clicks on this component, the user profile modal will be pushed

Linear task: https://linear.app/comm/issue/ENG-5243/make-user-profile-accessible-from-a-user-entity-in-a-robotext

Depends on D9483

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Oct 12 2023, 11:12 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 11:12 PM
ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 11:13 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9483: [web] make user profile accessible from member component.
ginsu attached a referenced file: F812240: Screen Recording 2023-10-13 at 2.12.46 AM.mov. (Show Details)
ginsu added a child revision: D9485: [web] introduce MessageReactionsListItem.Oct 12 2023, 11:17 PM
Harbormaster completed remote builds in B23234: Diff 31990.Oct 12 2023, 11:29 PM
ginsu requested review of this revision.Oct 12 2023, 11:29 PM
atul accepted this revision.Oct 16 2023, 12:04 PM
This revision is now accepted and ready to land.Oct 16 2023, 12:04 PM
ginsu updated this revision to Diff 32098.Oct 17 2023, 11:53 AM

rebase before landing

Harbormaster completed remote builds in B23303: Diff 32098.Oct 17 2023, 12:28 PM
Closed by commit rCOMMfecb5bd5183f: [web] make user profile accessible from user entity robotext (authored by ginsu). · Explain WhyOct 17 2023, 2:53 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMfecb5bd5183f: [web] make user profile accessible from user entity robotext.

Revision Contents
Changeset List

PathSize
web/
chat/
11 lines

Diff 32098

View Options

web/chat/robotext-message.react.js

Loading...