Page MenuHomePhabricator
Differential D9488

[web] introduce MarkdownUserMention component
ClosedPublic
Actions

Authored by ginsu on Oct 13 2023, 12:42 PM.
Tags
None
Referenced Files
F2903595: D9488.id31997.diff
Sat, Oct 5, 11:16 PM
F2903564: D9488.id32101.diff
Sat, Oct 5, 10:55 PM
Unknown Object (File)
Wed, Oct 2, 10:10 AM
Unknown Object (File)
Wed, Oct 2, 10:10 AM
Unknown Object (File)
Wed, Oct 2, 10:10 AM
Unknown Object (File)
Wed, Oct 2, 10:03 AM
Unknown Object (File)
Wed, Oct 2, 6:02 AM
Unknown Object (File)
Thu, Sep 12, 9:01 AM
View All 64 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM7ffb4ac5f1f3: [web] introduce MarkdownUserMention component
Summary

This diff makes the @mention of a user interactive with the introduction of this component. When a user clicks on this component, the user profile modal will be pushed

Linear Task: https://linear.app/comm/issue/ENG-5245/make-user-profile-accessible-from-markdown-user-mention

Depends on D9486

Test Plan

Please see the demo video below:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 13 2023, 12:42 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 13 2023, 12:42 PM
ginsu edited the summary of this revision. (Show Details)Oct 13 2023, 12:48 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9486: [web] make user profile accessible from message reactions list item.
ginsu attached a referenced file: F813206: Screen Recording 2023-10-13 at 3.47.38 PM.mov. (Show Details)
Harbormaster completed remote builds in B23241: Diff 31997.Oct 13 2023, 1:01 PM
ginsu requested review of this revision.Oct 13 2023, 1:01 PM
ginsu added a child revision: D9495: [web] introduce FullScreenViewModal.Oct 15 2023, 8:48 PM
atul accepted this revision.Oct 16 2023, 12:25 PM
atul added inline comments.
web/markdown/markdown-user-mention.react.js
18–22 ↗(On Diff #31997)

Doesn't hurt to memoize

This revision is now accepted and ready to land.Oct 16 2023, 12:25 PM
ginsu updated this revision to Diff 32101.Oct 17 2023, 12:06 PM

address @atul's comments + rebase before landing

Harbormaster completed remote builds in B23306: Diff 32101.Oct 17 2023, 12:25 PM
Closed by commit rCOMM7ffb4ac5f1f3: [web] introduce MarkdownUserMention component (authored by ginsu). · Explain WhyOct 17 2023, 2:53 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7ffb4ac5f1f3: [web] introduce MarkdownUserMention component.

Revision Contents
Changeset List

Diff 32120

View Options

web/markdown/markdown-chat-mention.react.js

Loading...
View Options

web/markdown/markdown-user-mention.react.js

Loading...
View Options

web/markdown/markdown.css

Loading...
View Options

web/markdown/rules.react.js

Loading...