Page MenuHomePhabricator
Differential D9356

[lib][web][native] Refactor actions in entry-actions.js
ClosedPublic
Actions

Authored by inka on Oct 4 2023, 6:29 AM.
Tags
None
Referenced Files
F2902886: D9356.id32619.diff
Sat, Oct 5, 7:30 PM
F2902502: D9356.diff
Sat, Oct 5, 5:50 PM
Unknown Object (File)
Sun, Sep 29, 2:45 AM
Unknown Object (File)
Sun, Sep 29, 2:42 AM
Unknown Object (File)
Fri, Sep 13, 4:24 AM
Unknown Object (File)
Sat, Sep 7, 12:07 AM
Unknown Object (File)
Fri, Sep 6, 4:50 PM
Unknown Object (File)
Fri, Sep 6, 4:50 PM
View All 77 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
michal
kamil
ginsu
Commits
rCOMM5385e2eddc97: [lib][web][native] Refactor actions in entry-actions.js
Summary

issue: https://linear.app/comm/issue/ENG-4681/create-action-objects-for-all-actions

Test Plan

Tested that the actions work as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka created this revision.Oct 4 2023, 6:29 AM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 4 2023, 6:29 AM
inka added a parent revision: D9353: [lib] Refactor actions in activity-actions.js.Oct 4 2023, 6:30 AM
Harbormaster completed remote builds in B22969: Diff 31633.Oct 4 2023, 6:47 AM
inka requested review of this revision.Oct 4 2023, 6:47 AM
inka added a child revision: D9368: [lib][web][native] Refactor actions in link-actions.js.Oct 5 2023, 6:19 AM
michal requested changes to this revision.Oct 11 2023, 1:16 AM
michal added inline comments.
lib/actions/entry-actions.js
80 ↗(On Diff #31633)

CalendarQuery.filters may be CalendarThreadFilter which contain threadIDs so we need to create a new a calendarQuery for each keyserver with only the threads it is interested in.

This revision now requires changes to proceed.Oct 11 2023, 1:16 AM
inka added a parent revision: D9644: [lib] Add function for splitting calendar query per keyserver.Nov 2 2023, 6:43 AM
inka removed a parent revision: D9353: [lib] Refactor actions in activity-actions.js.
inka updated this revision to Diff 32619.Nov 2 2023, 7:16 AM

Separate query per keyserver

Harbormaster completed remote builds in B23665: Diff 32619.Nov 2 2023, 7:36 AM
michal accepted this revision.Nov 3 2023, 5:16 AM
This revision is now accepted and ready to land.Nov 3 2023, 5:16 AM
Closed by commit rCOMM5385e2eddc97: [lib][web][native] Refactor actions in entry-actions.js (authored by inka). · Explain WhyNov 6 2023, 5:44 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMM5385e2eddc97: [lib][web][native] Refactor actions in entry-actions.js.
ashoat mentioned this in D12255: [lib] Fix createEntry action.May 31 2024, 5:52 AM
ashoat mentioned this in rCOMMf3fc775546f4: [lib] Fix createEntry action.Jun 3 2024, 8:11 AM

Revision Contents
Changeset List

PathSize
lib/
actions/
262 lines
socket/
14 lines
native/
calendar/
11 lines
13 lines
web/
calendar/
19 lines
13 lines
modals/
history/
5 lines
14 lines

Diff 32758

View Options

lib/actions/entry-actions.js

Loading...
View Options

lib/socket/calendar-query-handler.react.js

Loading...
View Options

native/calendar/calendar.react.js

Loading...
View Options

native/calendar/entry.react.js

Loading...
View Options

web/calendar/calendar.react.js

Loading...
View Options

web/calendar/entry.react.js

Loading...
View Options

web/modals/history/history-entry.react.js

Loading...
View Options

web/modals/history/history-modal.react.js

Loading...