Page MenuHomePhabricator
Differential D9658

[keyserver] Move update delete condition to a spec
ClosedPublic
Actions

Authored by tomek on Oct 31 2023, 8:56 AM.
Tags
None
Referenced Files
F2192011: D9658.id32753.diff
Thu, Jul 4, 6:37 PM
F2185533: D9658.id32558.diff
Thu, Jul 4, 12:17 AM
F2184850: D9658.id32777.diff
Wed, Jul 3, 10:12 PM
Unknown Object (File)
Tue, Jul 2, 6:29 PM
Unknown Object (File)
Tue, Jul 2, 4:48 PM
Unknown Object (File)
Sat, Jun 29, 8:02 PM
Unknown Object (File)
Fri, Jun 28, 10:34 AM
Unknown Object (File)
Fri, Jun 28, 10:34 AM
View All 40 Files
Subscribers
ashoat
will

Details

Reviewers
kamil
inka
bartek
Commits
rCOMMeeed0650fd0b: [keyserver] Move update delete condition to a spec
Summary

Add a field to a spec defining delete condition for a type.

Depends on D9657

Test Plan

Generate some updates, reintroduce old code, and compare new with old result using _.isEqual

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Oct 31 2023, 8:56 AM
Herald added subscribers: will, ashoat. · View Herald TranscriptOct 31 2023, 8:56 AM
tomek added a child revision: D9659: [keyserver] Simplify updates merging.Oct 31 2023, 9:00 AM
Harbormaster completed remote builds in B23615: Diff 32558.Oct 31 2023, 10:02 AM
tomek requested review of this revision.Oct 31 2023, 10:02 AM
kamil accepted this revision.Nov 2 2023, 9:37 AM
kamil added inline comments.
keyserver/src/creators/update-creator.js
72 ↗(On Diff #32558)

it's used twice, can we make a type alias?

This revision is now accepted and ready to land.Nov 2 2023, 9:37 AM
kamil mentioned this in D9660: [keyserver] Move merging of updates to a spec.Nov 3 2023, 2:54 AM
tomek updated this revision to Diff 32753.Nov 6 2023, 5:17 AM

Create shared type

Harbormaster completed remote builds in B23785: Diff 32753.Nov 6 2023, 5:36 AM
Closed by commit rCOMMeeed0650fd0b: [keyserver] Move update delete condition to a spec (authored by tomek). · Explain WhyNov 6 2023, 6:59 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMeeed0650fd0b: [keyserver] Move update delete condition to a spec.

Revision Contents
Changeset List

Diff 32777

View Options

keyserver/src/creators/update-creator.js

Loading...
View Options

lib/shared/updates/bad-device-token-spec.js

Loading...
View Options

lib/shared/updates/delete-account-spec.js

Loading...
View Options

lib/shared/updates/delete-thread-spec.js

Loading...
View Options

lib/shared/updates/join-thread-spec.js

Loading...
View Options

lib/shared/updates/update-current-user-spec.js

Loading...
View Options

lib/shared/updates/update-entry-spec.js

Loading...
View Options

lib/shared/updates/update-spec.js

Loading...
View Options

lib/shared/updates/update-thread-read-status-spec.js

Loading...
View Options

lib/shared/updates/update-thread-spec.js

Loading...
View Options

lib/shared/updates/update-user-spec.js

Loading...