Page MenuHomePhabricator

[keyserver] Block creating invite links for which an entry in Blob service already exists
ClosedPublic

Authored by tomek on Nov 21 2023, 8:26 AM.
Tags
None
Referenced Files
F3369614: D9944.id36403.diff
Mon, Nov 25, 11:00 PM
Unknown Object (File)
Sat, Nov 23, 12:27 AM
Unknown Object (File)
Tue, Nov 12, 6:42 PM
Unknown Object (File)
Tue, Nov 12, 7:36 AM
Unknown Object (File)
Mon, Nov 11, 3:29 PM
Unknown Object (File)
Mon, Nov 11, 2:24 AM
Unknown Object (File)
Sun, Nov 10, 11:24 PM
Unknown Object (File)
Sun, Nov 10, 11:40 AM
Subscribers

Details

Summary

If a keyserver tries to create a link for which an entry exists, it means that a link was already created by some keyserver. Only one link can exist with a given name, so we have to block such an attempt.

Depends on D9943

Test Plan

Create a blob with invite_${secret} hash and check if it is impossible to create a link with the same secret. Also check if it is still possible to create other links.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.Nov 21 2023, 8:45 AM
This revision is now accepted and ready to land.Nov 21 2023, 11:29 AM
keyserver/src/creators/invite-link-creator.js
152

This doesn't need to be an async function