[web] save the recently deleted server url to customServer redux state
ClosedPublic
Actions

Authored by ginsu on Nov 29 2023, 1:08 AM.

Details

Reviewers

inka
rohan
michal

Commits

rCOMM22222927772e: [web] save the recently deleted server url to customServer redux state

Summary

if a server is removed from the list, and the user is staff or in dev mode, we want this url to be saved to customServer. This diff implements this functionality.

Linear task: https://linear.app/comm/issue/ENG-5498/introduce-onpress-remove-selected-keyserver-function

Depends on D10092

Test Plan

Please see demo video below

Diff Detail

Repository

rCOMM Comm

Branch

eng-5189 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Nov 29 2023, 1:08 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 29 2023, 1:08 AM

ginsu edited the summary of this revision. (Show Details)Nov 29 2023, 1:18 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: inka, rohan, michal.

ginsu added a parent revision: D10092: [lib/native/web] lift customServer redux state into lib.

Harbormaster completed remote builds in B24605: Diff 33984.Nov 29 2023, 1:41 AM

ginsu requested review of this revision.Nov 29 2023, 1:41 AM

ginsu added a child revision: D10094: [web] implement onClickAddKeyserver callback.Nov 29 2023, 1:57 AM

rohan accepted this revision.Nov 29 2023, 6:18 PM

This revision is now accepted and ready to land.Nov 29 2023, 6:18 PM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 4 2023, 11:02 PM

Closed by commit rCOMM22222927772e: [web] save the recently deleted server url to customServer redux state (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM22222927772e: [web] save the recently deleted server url to customServer redux state.

Harbormaster completed remote builds in B24788: Diff 34253.Dec 4 2023, 11:35 PM

Revision Contents
Changeset List

Path

Size

web/

modals/

keyserver-selection/

keyserver-selection-modal.react.js

19 lines

Diff 33984

View Options

web/modals/keyserver-selection/keyserver-selection-modal.react.js

[web] save the recently deleted server url to customServer redux stateClosedPublicActions