Page MenuHomePhabricator
Differential D10664

[native][web] Make identity client mandatory
ClosedPublic
Actions

Authored by tomek on Jan 17 2024, 8:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 3:02 AM
Unknown Object (File)
Fri, Mar 7, 8:20 PM
Unknown Object (File)
Fri, Mar 7, 1:05 PM
Unknown Object (File)
Mon, Feb 24, 7:33 AM
Unknown Object (File)
Sat, Feb 22, 1:09 PM
Unknown Object (File)
Sat, Feb 22, 1:09 PM
Unknown Object (File)
Sat, Feb 22, 1:09 PM
Unknown Object (File)
Sat, Feb 22, 1:09 PM
View All 100 Files
Subscribers
ashoat

Details

Reviewers
varun
inka
kamil
ashoat
Commits
rCOMMd5ef4a27085a: [native][web] Make identity client mandatory
Summary

Replace effect with memo and make the value mandatory which simplifies its usage.

Depends on D10663

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jan 17 2024, 8:03 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 17 2024, 8:03 AM
tomek removed a reviewer: marcin.Jan 17 2024, 8:06 AM
tomek added a child revision: D10665: [lib] Improve error handling in connection handler.Jan 17 2024, 8:07 AM
Harbormaster completed remote builds in B25837: Diff 35726.Jan 17 2024, 8:21 AM
tomek requested review of this revision.Jan 17 2024, 8:21 AM
ashoat accepted this revision.Jan 17 2024, 8:24 AM
ashoat added inline comments.
native/identity-service/identity-service-context-provider.react.js
63–91 ↗(On Diff #35726)

Nit: this can be slightly simplified

This revision is now accepted and ready to land.Jan 17 2024, 8:24 AM
tomek updated this revision to Diff 35808.Jan 18 2024, 9:49 AM

Simplify

Harbormaster completed remote builds in B25907: Diff 35808.Jan 18 2024, 10:08 AM
tomek updated this revision to Diff 35874.Jan 19 2024, 6:22 AM

Rebase

Harbormaster completed remote builds in B25952: Diff 35874.Jan 19 2024, 6:40 AM
Closed by commit rCOMMd5ef4a27085a: [native][web] Make identity client mandatory (authored by tomek). · Explain WhyJan 19 2024, 8:03 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMd5ef4a27085a: [native][web] Make identity client mandatory.

Revision Contents
Changeset List

Diff 35808

View Options

lib/shared/identity-client-context.js

Show First 20 Lines • Show All 298 Lines • ▼ Show 20 Linesbool add_not_null_constraint_to_metadata(sqlite3 *db) {
stringStream << "Error adding NOT NULL constraint to metadata table: " stringStream << "Error adding NOT NULL constraint to metadata table: "
<< error; << error;
Logger::log(stringStream.str()); Logger::log(stringStream.str());
sqlite3_free(error); sqlite3_free(error);
return false; return false;
} }
bool add_avatar_column_to_threads_table(sqlite3 *db) {
char *error;
sqlite3_exec(
db,
"ALTER TABLE threads ADD COLUMN avatar TEXT;",
nullptr,
nullptr,
&error);
if (!error) {
return true;
}
std::ostringstream stringStream;
stringStream << "Error adding avatar column to threads table: " << error;
Logger::log(stringStream.str());
sqlite3_free(error);
return false;
}
bool create_schema(sqlite3 *db) { bool create_schema(sqlite3 *db) {
char *error; char *error;
sqlite3_exec( sqlite3_exec(
db, db,
"CREATE TABLE IF NOT EXISTS drafts (" "CREATE TABLE IF NOT EXISTS drafts ("
" key TEXT UNIQUE PRIMARY KEY NOT NULL," " key TEXT UNIQUE PRIMARY KEY NOT NULL,"
" text TEXT NOT NULL" " text TEXT NOT NULL"
");" ");"
Show All 37 Lines sqlite3_exec(
" creation_time BIGINT NOT NULL," " creation_time BIGINT NOT NULL,"
" parent_thread_id TEXT," " parent_thread_id TEXT,"
" containing_thread_id TEXT," " containing_thread_id TEXT,"
" community TEXT," " community TEXT,"
" members TEXT NOT NULL," " members TEXT NOT NULL,"
" roles TEXT NOT NULL," " roles TEXT NOT NULL,"
" current_user TEXT NOT NULL," " current_user TEXT NOT NULL,"
" source_message_id TEXT," " source_message_id TEXT,"
" replies_count INTEGER NOT NULL" " replies_count INTEGER NOT NULL,"
" avatar TEXT"
");" ");"
"CREATE TABLE IF NOT EXISTS metadata (" "CREATE TABLE IF NOT EXISTS metadata ("
" name TEXT UNIQUE PRIMARY KEY NOT NULL," " name TEXT UNIQUE PRIMARY KEY NOT NULL,"
" data TEXT NOT NULL" " data TEXT NOT NULL"
");" ");"
"CREATE INDEX IF NOT EXISTS media_idx_container" "CREATE INDEX IF NOT EXISTS media_idx_container"
▲ Show 20 Lines • Show All 225 Lines • ▼ Show 20 Linesstd::vector<std::pair<uint, SQLiteMigration>> migrations{
{17, {recreate_messages_table, true}}, {17, {recreate_messages_table, true}},
{18, {create_messages_idx_thread_time, true}}, {18, {create_messages_idx_thread_time, true}},
{19, {create_media_idx_container, true}}, {19, {create_media_idx_container, true}},
{20, {create_threads_table, true}}, {20, {create_threads_table, true}},
{21, {update_threadID_for_pending_threads_in_drafts, true}}, {21, {update_threadID_for_pending_threads_in_drafts, true}},
{22, {enable_write_ahead_logging_mode, false}}, {22, {enable_write_ahead_logging_mode, false}},
{23, {create_metadata_table, true}}, {23, {create_metadata_table, true}},
{24, {add_not_null_constraint_to_drafts, true}}, {24, {add_not_null_constraint_to_drafts, true}},
{25, {add_not_null_constraint_to_metadata, true}}}}; {25, {add_not_null_constraint_to_metadata, true}},
{26, {add_avatar_column_to_threads_table, true}}}};
enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED }; enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED };
MigrationResult applyMigrationWithTransaction( MigrationResult applyMigrationWithTransaction(
sqlite3 *db, sqlite3 *db,
const MigrateFunction &migrate, const MigrateFunction &migrate,
int index) { int index) {
sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr); sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr);
▲ Show 20 Lines • Show All 184 Lines • ▼ Show 20 Lines static auto storage = make_storage(
make_column("creation_time", &Thread::creation_time), make_column("creation_time", &Thread::creation_time),
make_column("parent_thread_id", &Thread::parent_thread_id), make_column("parent_thread_id", &Thread::parent_thread_id),
make_column("containing_thread_id", &Thread::containing_thread_id), make_column("containing_thread_id", &Thread::containing_thread_id),
make_column("community", &Thread::community), make_column("community", &Thread::community),
make_column("members", &Thread::members), make_column("members", &Thread::members),
make_column("roles", &Thread::roles), make_column("roles", &Thread::roles),
make_column("current_user", &Thread::current_user), make_column("current_user", &Thread::current_user),
make_column("source_message_id", &Thread::source_message_id), make_column("source_message_id", &Thread::source_message_id),
make_column("replies_count", &Thread::replies_count)), make_column("replies_count", &Thread::replies_count),
make_column("avatar", &Thread::avatar)),
make_table( make_table(
"metadata", "metadata",
make_column("name", &Metadata::name, unique(), primary_key()), make_column("name", &Metadata::name, unique(), primary_key()),
make_column("data", &Metadata::data))); make_column("data", &Metadata::data)));
storage.on_open = on_database_open; storage.on_open = on_database_open;
return storage; return storage;
} }
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines
View Options

native/identity-service/identity-service-context-provider.react.js

Show First 20 Lines • Show All 298 Lines • ▼ Show 20 Linesbool add_not_null_constraint_to_metadata(sqlite3 *db) {
stringStream << "Error adding NOT NULL constraint to metadata table: " stringStream << "Error adding NOT NULL constraint to metadata table: "
<< error; << error;
Logger::log(stringStream.str()); Logger::log(stringStream.str());
sqlite3_free(error); sqlite3_free(error);
return false; return false;
} }
bool add_avatar_column_to_threads_table(sqlite3 *db) {
char *error;
sqlite3_exec(
db,
"ALTER TABLE threads ADD COLUMN avatar TEXT;",
nullptr,
nullptr,
&error);
if (!error) {
return true;
}
std::ostringstream stringStream;
stringStream << "Error adding avatar column to threads table: " << error;
Logger::log(stringStream.str());
sqlite3_free(error);
return false;
}
bool create_schema(sqlite3 *db) { bool create_schema(sqlite3 *db) {
char *error; char *error;
sqlite3_exec( sqlite3_exec(
db, db,
"CREATE TABLE IF NOT EXISTS drafts (" "CREATE TABLE IF NOT EXISTS drafts ("
" key TEXT UNIQUE PRIMARY KEY NOT NULL," " key TEXT UNIQUE PRIMARY KEY NOT NULL,"
" text TEXT NOT NULL" " text TEXT NOT NULL"
");" ");"
Show All 37 Lines sqlite3_exec(
" creation_time BIGINT NOT NULL," " creation_time BIGINT NOT NULL,"
" parent_thread_id TEXT," " parent_thread_id TEXT,"
" containing_thread_id TEXT," " containing_thread_id TEXT,"
" community TEXT," " community TEXT,"
" members TEXT NOT NULL," " members TEXT NOT NULL,"
" roles TEXT NOT NULL," " roles TEXT NOT NULL,"
" current_user TEXT NOT NULL," " current_user TEXT NOT NULL,"
" source_message_id TEXT," " source_message_id TEXT,"
" replies_count INTEGER NOT NULL" " replies_count INTEGER NOT NULL,"
" avatar TEXT"
");" ");"
"CREATE TABLE IF NOT EXISTS metadata (" "CREATE TABLE IF NOT EXISTS metadata ("
" name TEXT UNIQUE PRIMARY KEY NOT NULL," " name TEXT UNIQUE PRIMARY KEY NOT NULL,"
" data TEXT NOT NULL" " data TEXT NOT NULL"
");" ");"
"CREATE INDEX IF NOT EXISTS media_idx_container" "CREATE INDEX IF NOT EXISTS media_idx_container"
▲ Show 20 Lines • Show All 225 Lines • ▼ Show 20 Linesstd::vector<std::pair<uint, SQLiteMigration>> migrations{
{17, {recreate_messages_table, true}}, {17, {recreate_messages_table, true}},
{18, {create_messages_idx_thread_time, true}}, {18, {create_messages_idx_thread_time, true}},
{19, {create_media_idx_container, true}}, {19, {create_media_idx_container, true}},
{20, {create_threads_table, true}}, {20, {create_threads_table, true}},
{21, {update_threadID_for_pending_threads_in_drafts, true}}, {21, {update_threadID_for_pending_threads_in_drafts, true}},
{22, {enable_write_ahead_logging_mode, false}}, {22, {enable_write_ahead_logging_mode, false}},
{23, {create_metadata_table, true}}, {23, {create_metadata_table, true}},
{24, {add_not_null_constraint_to_drafts, true}}, {24, {add_not_null_constraint_to_drafts, true}},
{25, {add_not_null_constraint_to_metadata, true}}}}; {25, {add_not_null_constraint_to_metadata, true}},
{26, {add_avatar_column_to_threads_table, true}}}};
enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED }; enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED };
MigrationResult applyMigrationWithTransaction( MigrationResult applyMigrationWithTransaction(
sqlite3 *db, sqlite3 *db,
const MigrateFunction &migrate, const MigrateFunction &migrate,
int index) { int index) {
sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr); sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr);
▲ Show 20 Lines • Show All 184 Lines • ▼ Show 20 Lines static auto storage = make_storage(
make_column("creation_time", &Thread::creation_time), make_column("creation_time", &Thread::creation_time),
make_column("parent_thread_id", &Thread::parent_thread_id), make_column("parent_thread_id", &Thread::parent_thread_id),
make_column("containing_thread_id", &Thread::containing_thread_id), make_column("containing_thread_id", &Thread::containing_thread_id),
make_column("community", &Thread::community), make_column("community", &Thread::community),
make_column("members", &Thread::members), make_column("members", &Thread::members),
make_column("roles", &Thread::roles), make_column("roles", &Thread::roles),
make_column("current_user", &Thread::current_user), make_column("current_user", &Thread::current_user),
make_column("source_message_id", &Thread::source_message_id), make_column("source_message_id", &Thread::source_message_id),
make_column("replies_count", &Thread::replies_count)), make_column("replies_count", &Thread::replies_count),
make_column("avatar", &Thread::avatar)),
make_table( make_table(
"metadata", "metadata",
make_column("name", &Metadata::name, unique(), primary_key()), make_column("name", &Metadata::name, unique(), primary_key()),
make_column("data", &Metadata::data))); make_column("data", &Metadata::data)));
storage.on_open = on_database_open; storage.on_open = on_database_open;
return storage; return storage;
} }
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines
View Options

web/grpc/identity-service-context-provider.react.js

Show First 20 Lines • Show All 298 Lines • ▼ Show 20 Linesbool add_not_null_constraint_to_metadata(sqlite3 *db) {
stringStream << "Error adding NOT NULL constraint to metadata table: " stringStream << "Error adding NOT NULL constraint to metadata table: "
<< error; << error;
Logger::log(stringStream.str()); Logger::log(stringStream.str());
sqlite3_free(error); sqlite3_free(error);
return false; return false;
} }
bool add_avatar_column_to_threads_table(sqlite3 *db) {
char *error;
sqlite3_exec(
db,
"ALTER TABLE threads ADD COLUMN avatar TEXT;",
nullptr,
nullptr,
&error);
if (!error) {
return true;
}
std::ostringstream stringStream;
stringStream << "Error adding avatar column to threads table: " << error;
Logger::log(stringStream.str());
sqlite3_free(error);
return false;
}
bool create_schema(sqlite3 *db) { bool create_schema(sqlite3 *db) {
char *error; char *error;
sqlite3_exec( sqlite3_exec(
db, db,
"CREATE TABLE IF NOT EXISTS drafts (" "CREATE TABLE IF NOT EXISTS drafts ("
" key TEXT UNIQUE PRIMARY KEY NOT NULL," " key TEXT UNIQUE PRIMARY KEY NOT NULL,"
" text TEXT NOT NULL" " text TEXT NOT NULL"
");" ");"
Show All 37 Lines sqlite3_exec(
" creation_time BIGINT NOT NULL," " creation_time BIGINT NOT NULL,"
" parent_thread_id TEXT," " parent_thread_id TEXT,"
" containing_thread_id TEXT," " containing_thread_id TEXT,"
" community TEXT," " community TEXT,"
" members TEXT NOT NULL," " members TEXT NOT NULL,"
" roles TEXT NOT NULL," " roles TEXT NOT NULL,"
" current_user TEXT NOT NULL," " current_user TEXT NOT NULL,"
" source_message_id TEXT," " source_message_id TEXT,"
" replies_count INTEGER NOT NULL" " replies_count INTEGER NOT NULL,"
" avatar TEXT"
");" ");"
"CREATE TABLE IF NOT EXISTS metadata (" "CREATE TABLE IF NOT EXISTS metadata ("
" name TEXT UNIQUE PRIMARY KEY NOT NULL," " name TEXT UNIQUE PRIMARY KEY NOT NULL,"
" data TEXT NOT NULL" " data TEXT NOT NULL"
");" ");"
"CREATE INDEX IF NOT EXISTS media_idx_container" "CREATE INDEX IF NOT EXISTS media_idx_container"
▲ Show 20 Lines • Show All 225 Lines • ▼ Show 20 Linesstd::vector<std::pair<uint, SQLiteMigration>> migrations{
{17, {recreate_messages_table, true}}, {17, {recreate_messages_table, true}},
{18, {create_messages_idx_thread_time, true}}, {18, {create_messages_idx_thread_time, true}},
{19, {create_media_idx_container, true}}, {19, {create_media_idx_container, true}},
{20, {create_threads_table, true}}, {20, {create_threads_table, true}},
{21, {update_threadID_for_pending_threads_in_drafts, true}}, {21, {update_threadID_for_pending_threads_in_drafts, true}},
{22, {enable_write_ahead_logging_mode, false}}, {22, {enable_write_ahead_logging_mode, false}},
{23, {create_metadata_table, true}}, {23, {create_metadata_table, true}},
{24, {add_not_null_constraint_to_drafts, true}}, {24, {add_not_null_constraint_to_drafts, true}},
{25, {add_not_null_constraint_to_metadata, true}}}}; {25, {add_not_null_constraint_to_metadata, true}},
{26, {add_avatar_column_to_threads_table, true}}}};
enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED }; enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED };
MigrationResult applyMigrationWithTransaction( MigrationResult applyMigrationWithTransaction(
sqlite3 *db, sqlite3 *db,
const MigrateFunction &migrate, const MigrateFunction &migrate,
int index) { int index) {
sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr); sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr);
▲ Show 20 Lines • Show All 184 Lines • ▼ Show 20 Lines static auto storage = make_storage(
make_column("creation_time", &Thread::creation_time), make_column("creation_time", &Thread::creation_time),
make_column("parent_thread_id", &Thread::parent_thread_id), make_column("parent_thread_id", &Thread::parent_thread_id),
make_column("containing_thread_id", &Thread::containing_thread_id), make_column("containing_thread_id", &Thread::containing_thread_id),
make_column("community", &Thread::community), make_column("community", &Thread::community),
make_column("members", &Thread::members), make_column("members", &Thread::members),
make_column("roles", &Thread::roles), make_column("roles", &Thread::roles),
make_column("current_user", &Thread::current_user), make_column("current_user", &Thread::current_user),
make_column("source_message_id", &Thread::source_message_id), make_column("source_message_id", &Thread::source_message_id),
make_column("replies_count", &Thread::replies_count)), make_column("replies_count", &Thread::replies_count),
make_column("avatar", &Thread::avatar)),
make_table( make_table(
"metadata", "metadata",
make_column("name", &Metadata::name, unique(), primary_key()), make_column("name", &Metadata::name, unique(), primary_key()),
make_column("data", &Metadata::data))); make_column("data", &Metadata::data)));
storage.on_open = on_database_open; storage.on_open = on_database_open;
return storage; return storage;
} }
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines