Paths

Table of Contentst

-
keyserver/src/cron/
-
src/
-
cron/
-
cron.js

[keyserver] Set a job that synchronizes links with blobs
ClosedPublic
Actions

Authored by tomek on Dec 6 2023, 6:39 AM.

Details

Reviewers

michal
bartek
rohan

Commits

rCOMM122195947a95: [keyserver] Set a job that synchronizes links with blobs

Summary

Run this script daily. It should happen after Blob service cleanup, which starts between midnight and 0:15 AM and currently takes up to a couple of minutes.

Depends on D10205

Test Plan

Modify the schedule and check if the script runs.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Dec 6 2023, 6:39 AM

Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2023, 6:39 AM

Fix

Harbormaster completed remote builds in B24823: Diff 34337.Dec 6 2023, 6:58 AM

Harbormaster completed remote builds in B24825: Diff 34339.Dec 6 2023, 7:17 AM

tomek requested review of this revision.Dec 6 2023, 7:17 AM

ashoat added inline comments.Dec 6 2023, 7:50 AM

keyserver/src/cron/cron.js
131 ↗	(On Diff #34339)	I had interpreted your previous request as wanting to include "in the keyserver's timezone" here, but seeing this I wonder if you are fine omitting it. Either way, I think we should be consistent

Looks good, I agree on having the comments consistent though

This revision is now accepted and ready to land.Dec 7 2023, 9:54 AM

tomek added a child revision: D10290: [lib] Modify link verification to call the proper keyserver.Dec 11 2023, 6:39 AM

Update comment

Harbormaster failed remote builds in B26416: Diff 36526!Feb 1 2024, 7:36 AM

Harbormaster completed remote builds in B26416: Diff 36526.Feb 1 2024, 7:51 AM

tomek mentioned this in D11076: [keyserver] Create invite link blobs in a migration.Feb 14 2024, 7:05 AM

Closed by commit rCOMM122195947a95: [keyserver] Set a job that synchronizes links with blobs (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM122195947a95: [keyserver] Set a job that synchronizes links with blobs.

tomek mentioned this in rCOMMa8b3efff9b29: [keyserver] Create invite link blobs in a migration.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

cron/

cron.js

14 lines

Diff 36526

View Options

keyserver/src/cron/cron.js

This file was added.

				#import "CommServicesAuthMetadataEmitter.h"

				#import <Foundation/Foundation.h>
				#import <React/RCTBridgeModule.h>
				#import <React/RCTEventEmitter.h>

				NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";

				@interface CommServicesAuthMetadataEmitterIOSWrapper
				marcinAuthorUnsubmitted Done Inline Actions It might look uncommon to have interface declaration and implementation next to each other in a single file but in fact we don't need to expose `CommServicesAuthMetadataIOSWrapper`. If we want to call `sendAuthMetadataToJS` from Objective - C we can use the common C++ API so let's avoid creating unnecessary files and duplication the same API. marcin: It might look uncommon to have interface declaration and implementation next to each other in a…
				bartekUnsubmitted Not Done Inline Actions It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes sense here bartek: It's not that uncommon 😉 I've seen this pattern already in some RN-related code and it makes…
				: RCTEventEmitter <RCTBridgeModule>
				@property(nonatomic) BOOL hasListeners;

				+ (void)sendToJSAccessToken:(NSString *)accessToken
				withUserID:(NSString *)userID
				withDeviceID:(NSString *)deviceID;
				bartekUnsubmitted Not Done Inline Actions What about `sendAccessTokenToJS: ... withUserID: ... withDeviceID`? Initially, I got confused because I understood `sendToJSAccessToken` as "send something to JS-based access token" 😅 bartek: What about `sendAccessTokenToJS: ... withUserID: ... withDeviceID`? Initially, I got confused…
				varunUnsubmitted Not Done Inline Actions +1 varun: +1
				@end

				@implementation CommServicesAuthMetadataEmitterIOSWrapper

				RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);

				static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;

				- (instancetype)init {
				self = [super init];
				if (!self) {
				return self;
				}
				_hasListeners = NO;
				return self;
				}

				- (void)startObserving {
				@synchronized([self class]) {
				_hasListeners = YES;
				sharedInstance = self;
				}
				}

				- (void)stopObserving {
				@synchronized([self class]) {
				_hasListeners = NO;
				sharedInstance = nil;
				}
				}

				- (NSArray<NSString > )supportedEvents {
				return @[ commServicesAuthMetadata ];
				}

				- (NSDictionary *)constantsToExport {
				return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
				}

				+ (BOOL)requiresMainQueueSetup {
				return YES;
				}

				+ (void)sendToJSAccessToken:(NSString *)accessToken
				withUserID:(NSString *)userID
				withDeviceID:(NSString *)deviceID {
				@synchronized([self class]) {
				if (!sharedInstance) {
				return;
				}

				NSDictionary *eventBody = @{
				@"accessToken" : accessToken,
				@"userID" : userID,
				@"deviceID" : deviceID
				};

				[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
				}
				}

				@end

				namespace comm {

				void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
				rust::String accessToken,
				rust::String userID,
				rust::String deviceID) {
				NSString *accessTokenObjC =
				[NSString stringWithCString:std::string(accessToken).c_str()
				encoding:NSUTF8StringEncoding];
				NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
				encoding:NSUTF8StringEncoding];
				NSString *deviceIDObjC =
				[NSString stringWithCString:std::string(deviceID).c_str()
				encoding:NSUTF8StringEncoding];

				[CommServicesAuthMetadataEmitterIOSWrapper sendToJSAccessToken:accessTokenObjC
				withUserID:userIDObjC
				withDeviceID:deviceIDObjC];
				}
				} // namespace comm

[keyserver] Set a job that synchronizes links with blobsClosedPublicActions