Page MenuHomePhabricator

[lib] Do not provide overrides when we already know a keyserver
ClosedPublic

Authored by tomek on Dec 12 2023, 1:33 AM.
Tags
None
Referenced Files
F3390440: D10307.diff
Fri, Nov 29, 11:52 PM
F3386450: D10307.diff
Fri, Nov 29, 4:49 AM
Unknown Object (File)
Tue, Nov 26, 6:24 PM
Unknown Object (File)
Sat, Nov 23, 6:50 PM
Unknown Object (File)
Sat, Nov 23, 5:21 PM
Unknown Object (File)
Sat, Nov 23, 4:24 PM
Unknown Object (File)
Fri, Nov 22, 2:38 AM
Unknown Object (File)
Thu, Nov 21, 3:47 PM
Subscribers

Details

Summary

If we know a keyserver, we have a cookie for it. If we use an override, we don't send that cookie, which means that from the keyserver's point of view, we're a new user. The solution is to provide an override only if we don't already know a keyserver.

Depends on D10290

Test Plan

Provide an override to a local keyserver when a user is logged in, click a link and check if the login screen doesn't appear.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable