Page MenuHomePhabricator
Differential D10338

[web][native] Download invite link blob and use it as an override
ClosedPublic
Actions

Authored by tomek on Dec 14 2023, 6:52 AM.
Tags
None
Referenced Files
F3522051: D10338.id37093.diff
Mon, Dec 23, 5:39 AM
F3522050: D10338.id36712.diff
Mon, Dec 23, 5:39 AM
F3522049: D10338.id36531.diff
Mon, Dec 23, 5:39 AM
F3522048: D10338.id34640.diff
Mon, Dec 23, 5:39 AM
F3522039: D10338.id.diff
Mon, Dec 23, 5:39 AM
F3522036: D10338.diff
Mon, Dec 23, 5:39 AM
Unknown Object (File)
Wed, Dec 4, 3:51 PM
Unknown Object (File)
Nov 18 2024, 4:00 AM
View All 100 Files
Subscribers
ashoat

Details

Reviewers
michal
bartek
inka
rohan
Commits
rCOMMfd4b74535fd1: [web][native] Download invite link blob and use it as an override
Summary

Download a blob, parse it and use its content as a keyserver override.

Depends on D10311

Test Plan

Open a link on web for which a blob is downloaded and check if a blob is downloaded and its content is used correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Dec 14 2023, 6:52 AM
Herald added a subscriber: ashoat. · View Herald TranscriptDec 14 2023, 6:52 AM
tomek edited the test plan for this revision. (Show Details)Dec 14 2023, 6:53 AM
Harbormaster completed remote builds in B25075: Diff 34640.Dec 14 2023, 7:45 AM
tomek requested review of this revision.Dec 14 2023, 7:45 AM
bartek added inline comments.Dec 15 2023, 5:41 AM
lib/shared/invite-links.js
32–34 ↗(On Diff #34640)

The Content-Type header is redundant for the GET method because it doesn't have a request body.

39–40 ↗(On Diff #34640)

This should be possible.

inka added a comment.Dec 15 2023, 8:37 AM

Can we use KeyserverOverride in useVerifyInviteLink?

rohan resigned from this revision.Dec 19 2023, 9:10 PM

I'll leave this to the other reviewers as it seems like they have some more context/feedback here

tomek planned changes to this revision.Dec 21 2023, 12:45 AM
tomek updated this revision to Diff 36531.Feb 1 2024, 8:04 AM
tomek marked 2 inline comments as done.

Rebase and address comments

Harbormaster completed remote builds in B26421: Diff 36531.Feb 1 2024, 8:23 AM
tomek updated this revision to Diff 36712.Feb 6 2024, 6:41 AM

Simplify the approach

tomek edited parent revisions, added: D10308: [keyserver] Modify link verification so that it works with users that aren't logged in to a keyserver; removed: D10311: [lib] Allow overriding a keyserver in a function returned from useKeyserverCall hook.Feb 6 2024, 6:42 AM
Harbormaster completed remote builds in B26565: Diff 36712.Feb 6 2024, 6:59 AM
bartek accepted this revision.Feb 7 2024, 1:14 AM
This revision is now accepted and ready to land.Feb 7 2024, 1:14 AM
tomek added a child revision: D10991: [native][web][lib] Extract common invite link logic.Feb 8 2024, 3:50 AM
Closed by commit rCOMMfd4b74535fd1: [web][native] Download invite link blob and use it as an override (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMfd4b74535fd1: [web][native] Download invite link blob and use it as an override.

Revision Contents
Changeset List

PathSize
lib/
actions/
10 lines
shared/
37 lines
native/
navigation/
70 lines
web/
invite-links/
83 lines

Diff 37093

View Options

lib/actions/link-actions.js

Loading...
View Options

lib/shared/invite-links.js

Loading...
View Options

native/navigation/deep-links-context-provider.react.js

Loading...
View Options

web/invite-links/invite-link-handler.react.js

Loading...