Differential D10992
[lib] Join a community on an overridden keyserver Authored by tomek on Feb 8 2024, 5:56 AM. Tags None Referenced Files
Subscribers
Details In order to join a keyserver we need to make sure that the user is authenticated. To do that, we need to make sure that the keyserver is present in the store and that the keyserver connection handler successfully performed the auth. The solution is to replace a simple async action with creating a new promise, that is resolved or rejected after a timeout or after a successful or unsuccessful join operation. Depends on D10991 Check on web that:
I haven't tested if joining a community works when the handler performs successful auth - this requires first testing https://linear.app/comm/issue/ENG-6114/final-testing-task
Diff Detail
Event Timeline
Comment Actions This code is quite complex in the case you were not able to test - when we connect to a different keyserver, and even mo so when we connect to a couple of keyservers. I can see that it would be hard to test now, but it would be great if you could create a linear task describing how this should be tested once it's possible, and set it as blocked by appropriate tasks. We talked about this diff offline, and all my issues were addressed, so other than that I think this code is fine Comment Actions Update the description of https://linear.app/comm/issue/ENG-6114/final-testing-task - we should test the links as a part of end-to-end connection handlers testing | ||||||||||||||||||||||||||||||||||