Paths

Table of Contentst

[lib] Add keyserverID param to getClientResponsesSelector
ClosedPublic
Actions

Authored by tomek on Feb 26 2024, 2:37 PM.

Details

Reviewers

michal
atul
inka
kamil

Commits

rCOMMc34612666172: [lib] Add keyserverID param to getClientResponsesSelector

Summary

The selector needs to be aware of the keyserver that sent a message to prepare the correct response.

https://linear.app/comm/issue/ENG-6522/provide-a-keyserver-id-to-getclientresponsesselector-function

Depends on D11144

Test Plan

Console logged the value of keyserverID in getClientResponsesSelector on both web and native

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 26 2024, 2:37 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 26 2024, 2:37 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 26 2024, 2:44 PM

Harbormaster failed remote builds in B27178: Diff 37610!

tomek added a child revision: D11177: [lib][keyserver] Delete MORE_ONE_TIME_KEYS mechanism.Feb 26 2024, 4:20 PM

tomek requested review of this revision.Feb 26 2024, 4:21 PM

atul accepted this revision.Feb 26 2024, 10:19 PM

This revision is now accepted and ready to land.Feb 26 2024, 10:19 PM

Harbormaster completed remote builds in B27178: Diff 37610.Feb 26 2024, 11:49 PM

Closed by commit rCOMMc34612666172: [lib] Add keyserverID param to getClientResponsesSelector. · Explain WhyFeb 27 2024, 9:41 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMc34612666172: [lib] Add keyserverID param to getClientResponsesSelector.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

socket-selectors.js

4 lines

native/

selectors/

socket-selectors.js

7 lines

socket.react.js

1 line

web/

selectors/

socket-selectors.js

3 lines

socket.react.js

1 line

Diff 37645

View Options

lib/selectors/socket-selectors.js

View Options

native/selectors/socket-selectors.js

View Options

native/socket.react.js

View Options

web/selectors/socket-selectors.js

View Options

[lib] Add keyserverID param to getClientResponsesSelectorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37645

lib/selectors/socket-selectors.js

native/selectors/socket-selectors.js

native/socket.react.js

web/selectors/socket-selectors.js

web/socket.react.js

[lib] Add keyserverID param to getClientResponsesSelector
ClosedPublic
Actions

Revision Contents
Changeset List