Page MenuHomePhabricator
Differential D11397

[native_rust_library] use farcaster id on register_wallet_user and register_password_user
AbandonedPublicDraft
Actions

Authored by varun on Mar 27 2024, 12:28 PM.
Tags
None
Referenced Files
F3873623: D11397.diff
Thu, Jan 23, 9:12 AM
Unknown Object (File)
Sun, Jan 19, 5:45 AM
Unknown Object (File)
Sun, Jan 19, 4:55 AM
Unknown Object (File)
Thu, Jan 9, 4:35 AM
Unknown Object (File)
Thu, Jan 9, 4:33 AM
Unknown Object (File)
Thu, Jan 9, 3:21 AM
Unknown Object (File)
Dec 16 2024, 9:22 AM
Unknown Object (File)
Nov 13 2024, 5:28 AM
View All 43 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
Summary

add farcaster_id param to both client methods

Depends on D11396

Test Plan

called the client methods and confirmed that the farcasterID was persisted in DDB when provided

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Mar 27 2024, 12:28 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 27 2024, 12:28 PM
varun added a child revision: D11398: [native] expose farcaster id param to native identity service context provider.Mar 27 2024, 12:31 PM
varun added inline comments.Mar 27 2024, 12:33 PM
native/native_rust_library/src/lib.rs
80

We can send a single JSON string instead of all these params. I'll remove these TODOs and create linear tasks before landing.

varun added a comment.Mar 27 2024, 12:37 PM

ah i need to squash D11398 with this diff

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 27 2024, 12:48 PM
Harbormaster failed remote builds in B27712: Diff 38375!
varun mentioned this in D11398: [native] expose farcaster id param to native identity service context provider.Mar 27 2024, 1:44 PM
varun abandoned this revision.Mar 27 2024, 1:45 PM

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
7 lines
12 lines
9 lines

Diff 38375

View Options

native/native_rust_library/src/farcaster.rs

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

native/native_rust_library/src/wallet_registration.rs

Loading...