Page MenuHomePhabricator
Differential D11612

[lib] Update `updateRelationshipInputValidator` to be union of `[traditional/farcaster]RelationshipRequestValidator`
ClosedPublic
Actions

Authored by atul on Apr 9 2024, 10:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 9:01 PM
Unknown Object (File)
Sat, Apr 27, 12:19 AM
Unknown Object (File)
Fri, Apr 26, 7:50 PM
Unknown Object (File)
Fri, Apr 26, 11:16 AM
Unknown Object (File)
Sun, Apr 21, 10:28 AM
Unknown Object (File)
Apr 16 2024, 10:09 PM
Unknown Object (File)
Apr 16 2024, 4:00 PM
Unknown Object (File)
Apr 16 2024, 9:35 AM
View All 13 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
varun
will
Commits
rCOMM811b86e47c66: [lib] Update `updateRelationshipInputValidator` to be union of `…
Summary

Update this validator so it supports requests of type TraditionalRelationshipRequest and FarcasterRelationshipRequest

Also renamed updateFarcasterRelationshipInputValidator to farcasterRelationshipRequestValidator for clarity and more consistent naming.

Depends on D11611

Test Plan

Send both TraditionalRelationshipRequest and FarcasterRelationshipRequest requests and ensure that they are validated by keyserver. Confirmed with log statements.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 9 2024, 10:19 PM
Herald added a subscriber: ashoat. · View Herald TranscriptApr 9 2024, 10:19 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 9 2024, 10:22 PM
Harbormaster failed remote builds in B28115: Diff 38971!
atul requested review of this revision.Apr 10 2024, 8:10 AM
Harbormaster completed remote builds in B28115: Diff 38971.Apr 10 2024, 10:05 AM
atul updated this revision to Diff 39009.Apr 10 2024, 12:22 PM

rebase

atul added a child revision: D11624: [lib] Fix `farcasterRelationshipRequestValidator`.Apr 10 2024, 12:47 PM
Harbormaster completed remote builds in B28141: Diff 39009.Apr 10 2024, 12:50 PM
tomek accepted this revision.Apr 11 2024, 8:26 AM
This revision is now accepted and ready to land.Apr 11 2024, 8:26 AM
atul updated this revision to Diff 39252.Thu, Apr 18, 1:21 PM

rebase and alnd

This revision was landed with ongoing or failed builds.Thu, Apr 18, 1:26 PM
Closed by commit rCOMM811b86e47c66: [lib] Update `updateRelationshipInputValidator` to be union of `… (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM811b86e47c66: [lib] Update `updateRelationshipInputValidator` to be union of `….
Harbormaster completed remote builds in B28311: Diff 39252.Thu, Apr 18, 2:07 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
11 lines
lib/
types/
2 lines
10 lines

Diff 39009

View Options

keyserver/src/responders/relationship-responders.js

Loading...
View Options

lib/types/relationship-types.js

Loading...
View Options

lib/types/relationship-types.test.js

Loading...