[native] Rename get/setCurrentUserID in CommCoreModule
ClosedPublic
Actions

Authored by ashoat on Apr 16 2024, 4:58 AM.

Details

Reviewers

tomek
inka

Commits

rCOMMc8d95123a827: [native] Rename get/setCurrentUserID in CommCoreModule

Summary

While working on ENG-7667, I spent some time reviewing this logic in SQLiteDataHandler on native. I found that the use of these methods might be more clear with a better name.

My mental model for it is:

A SQLite database is "stamped" once a user logs in
If a SQLite database is "stamped" with a given user ID, then it will deleted as soon as that user is not the current user

Test Plan

Flow
Compile the iOS app to a simulator and log in and log out. Make sure database is deleted

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Apr 16 2024, 4:58 AM

Open to different names, but I want to avoid currentUserID, so that we're not making it seem like this is duplicate data

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 16 2024, 5:11 AM

Harbormaster failed remote builds in B28237: Diff 39143!

Fix ESLint

Harbormaster completed remote builds in B28241: Diff 39151.Apr 16 2024, 7:02 AM

ashoat requested review of this revision.Apr 16 2024, 7:02 AM

I should probably also rename workerRequestMessageTypes.GET_CURRENT_USER_ID, workerRequestMessageTypes.SET_CURRENT_USER_ID, and any other related stuff

EDIT

Will do that in a separate diff... I think reviewers might be slightly different

EDIT 2

D11668

ashoat added a child revision: D11668: [web] Rename GET_/SET_CURRENT_USER_ID in shared worker.Tue, Apr 16, 11:48 AM

Should we regenerate a wasm file?

This revision is now accepted and ready to land.Wed, Apr 17, 4:32 AM