Page MenuHomePhabricator
Differential D11741

[lib] Simplify `threadMemberHasPermission()`
ClosedPublic
Actions

Authored by atul on Apr 23 2024, 10:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 4:58 PM
Unknown Object (File)
Fri, Apr 18, 11:33 AM
Unknown Object (File)
Fri, Apr 18, 7:44 AM
Unknown Object (File)
Fri, Apr 18, 6:05 AM
Unknown Object (File)
Thu, Apr 17, 8:54 PM
Unknown Object (File)
Thu, Apr 17, 11:13 AM
Unknown Object (File)
Mar 21 2025, 10:53 AM
Unknown Object (File)
Mar 13 2025, 11:45 AM
View All 85 Files
Subscribers
ashoat

Details

Reviewers
ginsu
tomek
varun
will
Commits
rCOMM24c5c5fc270d: [lib] Simplify `threadMemberHasPermission()`
Summary

This function is only consumed by appendUserInfo which is only consumed in usePotentialMemberItems. This hook is only used on client, so there's no need to support Server* or Legacy* types.

We can also skip .minimallyEncoded branch since all clients work exclusively with MinimallyEncoded* types at this point.

Depends on D11740

Test Plan

NA, flow and read through callsites.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
11 lines

Diff 39444

View Options

lib/shared/thread-utils.js

// @flow // @flow
import invariant from 'invariant';
import * as React from 'react'; import * as React from 'react';
import uuid from 'uuid'; import uuid from 'uuid';
import { import {
preparePushNotifs, preparePushNotifs,
prepareOwnDevicesPushNotifs,
type PerUserTargetedNotifications, type PerUserTargetedNotifications,
} from './send-utils.js'; } from './send-utils.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js'; import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import { NeynarClientContext } from '../components/neynar-client-provider.react.js'; import { NeynarClientContext } from '../components/neynar-client-provider.react.js';
import { usePeerOlmSessionsCreatorContext } from '../components/peer-olm-session-creator-provider.react.js'; import { usePeerOlmSessionsCreatorContext } from '../components/peer-olm-session-creator-provider.react.js';
import { thickRawThreadInfosSelector } from '../selectors/thread-selectors.js'; import { thickRawThreadInfosSelector } from '../selectors/thread-selectors.js';
import { IdentityClientContext } from '../shared/identity-client-context.js';
import { useTunnelbroker } from '../tunnelbroker/tunnelbroker-context.js'; import { useTunnelbroker } from '../tunnelbroker/tunnelbroker-context.js';
import type { import type {
TargetedAPNsNotification, TargetedAPNsNotification,
TargetedAndroidNotification, TargetedAndroidNotification,
TargetedWebNotification, TargetedWebNotification,
TargetedWNSNotification, TargetedWNSNotification,
NotificationsCreationData, NotificationsCreationData,
} from '../types/notif-types.js'; } from '../types/notif-types.js';
import { deviceToTunnelbrokerMessageTypes } from '../types/tunnelbroker/messages.js'; import { deviceToTunnelbrokerMessageTypes } from '../types/tunnelbroker/messages.js';
import type { import type {
TunnelbrokerAPNsNotif, TunnelbrokerAPNsNotif,
TunnelbrokerFCMNotif, TunnelbrokerFCMNotif,
TunnelbrokerWebPushNotif, TunnelbrokerWebPushNotif,
TunnelbrokerWNSNotif, TunnelbrokerWNSNotif,
} from '../types/tunnelbroker/notif-types.js'; } from '../types/tunnelbroker/notif-types.js';
import { getConfig } from '../utils/config.js'; import { getConfig } from '../utils/config.js';
import { getContentSigningKey } from '../utils/crypto-utils.js';
import { getMessageForException } from '../utils/errors.js'; import { getMessageForException } from '../utils/errors.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function apnsNotifToTunnelbrokerAPNsNotif( function apnsNotifToTunnelbrokerAPNsNotif(
targetedNotification: TargetedAPNsNotification, targetedNotification: TargetedAPNsNotification,
): TunnelbrokerAPNsNotif { ): TunnelbrokerAPNsNotif {
const { const {
deliveryID: deviceID, deliveryID: deviceID,
▲ Show 20 Lines • Show All 54 Lines • ▼ Show 20 Lines return {
clientMessageID: uuid.v4(), clientMessageID: uuid.v4(),
payload: JSON.stringify(notification), payload: JSON.stringify(notification),
}; };
} }
function useSendPushNotifs(): ( function useSendPushNotifs(): (
notifCreationData: ?NotificationsCreationData, notifCreationData: ?NotificationsCreationData,
) => Promise<?PerUserTargetedNotifications> { ) => Promise<?PerUserTargetedNotifications> {
const client = React.useContext(IdentityClientContext);
invariant(client, 'Identity context should be set');
const { getAuthMetadata } = client;
const rawMessageInfos = useSelector(state => state.messageStore.messages); const rawMessageInfos = useSelector(state => state.messageStore.messages);
const thickRawThreadInfos = useSelector(thickRawThreadInfosSelector); const thickRawThreadInfos = useSelector(thickRawThreadInfosSelector);
const auxUserInfos = useSelector(state => state.auxUserStore.auxUserInfos); const auxUserInfos = useSelector(state => state.auxUserStore.auxUserInfos);
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const { getENSNames } = React.useContext(ENSCacheContext); const { getENSNames } = React.useContext(ENSCacheContext);
const getFCNames = React.useContext(NeynarClientContext)?.getFCNames; const getFCNames = React.useContext(NeynarClientContext)?.getFCNames;
const { createOlmSessionsWithPeer: olmSessionCreator } = const { createOlmSessionsWithPeer: olmSessionCreator } =
usePeerOlmSessionsCreatorContext(); usePeerOlmSessionsCreatorContext();
const { sendNotif } = useTunnelbroker(); const { sendNotif } = useTunnelbroker();
const { encryptedNotifUtilsAPI } = getConfig(); const { encryptedNotifUtilsAPI } = getConfig();
return React.useCallback( return React.useCallback(
async (notifCreationData: ?NotificationsCreationData) => { async (notifCreationData: ?NotificationsCreationData) => {
if (!notifCreationData) { if (!notifCreationData) {
return; return;
} }
const deviceID = await getContentSigningKey(); const { deviceID, userID: senderUserID } = await getAuthMetadata();
if (!deviceID || !senderUserID) {
return;
}
const senderDeviceDescriptor = { senderDeviceID: deviceID }; const senderDeviceDescriptor = { senderDeviceID: deviceID };
const { messageDatas } = notifCreationData; const senderInfo = {
senderUserID,
senderDeviceDescriptor,
};
const { messageDatas, rescindData, badgeUpdateData } = notifCreationData;
const pushNotifsPreparationInput = { const pushNotifsPreparationInput = {
encryptedNotifUtilsAPI, encryptedNotifUtilsAPI,
senderDeviceDescriptor, senderDeviceDescriptor,
olmSessionCreator, olmSessionCreator,
messageInfos: rawMessageInfos, messageInfos: rawMessageInfos,
thickRawThreadInfos, thickRawThreadInfos,
auxUserInfos, auxUserInfos,
messageDatas, messageDatas,
userInfos, userInfos,
getENSNames, getENSNames,
getFCNames, getFCNames,
}; };
const preparedPushNotifs = await preparePushNotifs( const ownDevicesPushNotifsPreparationInput = {
pushNotifsPreparationInput, encryptedNotifUtilsAPI,
); senderInfo,
olmSessionCreator,
auxUserInfos,
rescindData,
badgeUpdateData,
};
const [preparedPushNotifs, preparedOwnDevicesPushNotifs] =
await Promise.all([
preparePushNotifs(pushNotifsPreparationInput),
prepareOwnDevicesPushNotifs(ownDevicesPushNotifsPreparationInput),
]);
if (!preparedPushNotifs) { if (!preparedPushNotifs && !prepareOwnDevicesPushNotifs) {
return; return;
} }
let allPreparedPushNotifs = preparedPushNotifs;
if (preparedOwnDevicesPushNotifs && senderUserID) {
allPreparedPushNotifs = {
...allPreparedPushNotifs,
[senderUserID]: preparedOwnDevicesPushNotifs,
};
}
const sendPromises = []; const sendPromises = [];
for (const userID in preparedPushNotifs) { for (const userID in allPreparedPushNotifs) {
for (const notif of preparedPushNotifs[userID]) { for (const notif of allPreparedPushNotifs[userID]) {
if (notif.targetedNotification.notification.encryptionFailed) { if (notif.targetedNotification.notification.encryptionFailed) {
continue; continue;
} }
let tunnelbrokerNotif; let tunnelbrokerNotif;
if (notif.platform === 'ios' || notif.platform === 'macos') { if (notif.platform === 'ios' || notif.platform === 'macos') {
tunnelbrokerNotif = apnsNotifToTunnelbrokerAPNsNotif( tunnelbrokerNotif = apnsNotifToTunnelbrokerAPNsNotif(
notif.targetedNotification, notif.targetedNotification,
Show All 28 Lines async (notifCreationData: ?NotificationsCreationData) => {
})(), })(),
); );
} }
} }
await Promise.all(sendPromises); await Promise.all(sendPromises);
}, },
[ [
getAuthMetadata,
sendNotif, sendNotif,
encryptedNotifUtilsAPI, encryptedNotifUtilsAPI,
olmSessionCreator, olmSessionCreator,
rawMessageInfos, rawMessageInfos,
thickRawThreadInfos, thickRawThreadInfos,
auxUserInfos, auxUserInfos,
userInfos, userInfos,
getENSNames, getENSNames,
getFCNames, getFCNames,
], ],
); );
} }
export { useSendPushNotifs }; export { useSendPushNotifs };